tailscale

Commit Graph

Author	SHA1	Message	Date
Andrew Dunham	280255acae	various: add golangci-lint, fix issues (#7905 ) This adds an initial and intentionally minimal configuration for golang-ci, fixes the issues reported, and adds a GitHub Action to check new pull requests against this linter configuration. Signed-off-by: Andrew Dunham <andrew@du.nham.ca> Change-Id: I8f38fbc315836a19a094d0d3e986758b9313f163	1 year ago
Mihai Parparita	bdc7a61c24	tool/gocross: add ts_macext build tag for Xcode builds It's used to control various opt-in functionality for the macOS and iOS apps, and was lost in the migration to gocross. Updates tailscale/tailscale#7769 Signed-off-by: Mihai Parparita <mihai@tailscale.com>	1 year ago
James Tucker	8c2b755b2e	tool/gocross: use grep -E over egrep to avoid warning Recent egrep builds produce a warning: ``` egrep: warning: egrep is obsolescent; using grep -E ``` Updates #cleanup Signed-off-by: James Tucker <james@tailscale.com>	1 year ago
David Anderson	c9a4dbe383	tool/gocross: correctly embed the git commit into gocross Previously, the build ended up embedding an empty string, which made the shell wrapper rebuild gocross on every invocation. This is still reasonably fast, but fixing the bypass shaves 80% off gocross's overhead when no rebuild is needed. Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	e7a78bc28f	tool/gocross: support running from outside the repo dir A bunch of us invoke tool/go from outside the repo that hosts gocross, as a way of accessing our version-controlled toolchain. This removes assumptions from gocross that it's being invoked within the repository that contains its source code and toolchain configuration. Fixes tailscale/corp#9627 Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	df02bb013a	tool/gocross: fail if the toolchain revision isn't findable This used to make sense, but after a refactor somewhere along the line this results in trying to download from a malformed URL and generally confusing failures. Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	0498d5ea86	tool/gocross: delete bootstrap tarball downloads after use Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	1f95bfedf7	tool/gocross: adjust Xcode flags to match new Xcode env Xcode changed how/what data it exports to build steps at some point recently, so our old way of figuring out the minimum support version for clang stopped working. Updates tailscale/corp#4095 Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	df3996cae3	tool/gocross: bootstrap correctly on an older toolchain Sometimes, our cached toolchain ends up being an older version of Go, older than our go.mod allows. In that scenario, gocross-wrapper.sh would find a usable toolchain, but then fail to compile gocross. This change makes the wrapper script check that the cached toolchain's minor version is good enough to build tailscale.com, and re-bootstraps in shell if not. Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	64181e17c8	tool/gocross: support local toolchain for development This makes gocross and its bootstrap script understand an absolute path in go.toolchain.rev to mean "use the given toolchain directly". Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	66621ab38e	tool/gocross: embed the version explicitly with linker flags We need to build gocross from multiple repos, but Go's innate git hash embedding only works when you build gocross from this repo, not when you build it from elsewhere via 'go build tailscale.com/tool/gocross'. Instead, explicitly embed the version found with 'git rev-parse HEAD', which will work from any git repo. Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	7444dabb68	tool/gocross: do all the bootstrap steps in a subshell This avoids accidentally overwriting variables from the input environment, which might non-deterministically change the behavior of gocross. Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	7e65a11df5	tool/gocross: write the wrapper script directly, rather than printing Turns out directing the printed script into the bootstrap location leads to irritating "text file busy" problems and then having to muck about with tempfiles and chmod and all that. Instead, have gocross write everything with the right values. Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	499d82af8a	tool/gocross: add command to print the wrapper shell script So that when importing and using gocross from other repos, there's an easy way to get at the right wrapper script that's in sync with the gocross binary. Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
David Anderson	860734aed9	tool/gocross: a tool for building Tailscale binaries Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago

15 Commits (280255acae604796a1113861f5a84e6fa2dc6121)