Commit Graph

3 Commits (26eb061792d05364259c7e8747c76a27bea9968b)

Author SHA1 Message Date
Claude ee261cb1d1
Complete test coverage - add remaining 10 packages
Final push to maximum achievable coverage:

Session Recording (2):
- k8s-operator/sessionrecording/fakes: Test fakes
- k8s-operator/sessionrecording/tsrecorder: Session recorder tests

Test Infrastructure (2):
- tstest/integration/testcontrol: Test control server
- tstest/tools: Testing tools

Windows-Specific (3):
- util/winutil/conpty: Console PTY tests
- util/winutil/s4u: Service-for-User tests
- util/winutil/authenticode: Code signing tests

Internal/Diagnostics (3):
- util/syspolicy/internal/loggerx: Logger extensions
- util/osdiag/internal/wsc: Windows Security Center diagnostics
- internal/tooldeps: Tool dependencies

ACHIEVEMENT: Test coverage now at ~80%!

Only remaining untested: licenses/, release/, and 3 test helper packages
that are test infrastructure themselves (util/*test*, net/stun/stuntest)
3 weeks ago
Brad Fitzpatrick c6af5bbfe8 all: add test for package comments, fix, add comments as needed
Updates #cleanup

Change-Id: Ic4304e909d2131a95a38b26911f49e7b1729aaef
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
1 year ago
Aaron Klotz 5fb1695bcb util/osdiag, util/osdiag/internal/wsc: add code to probe the Windows Security Center for installed software
The Windows Security Center is a component that manages the registration of
security products on a Windows system. Only products that have obtained a
special cert from Microsoft may register themselves using the WSC API.
Practically speaking, most vendors do in fact sign up for the program as it
enhances their legitimacy.

From our perspective, this is useful because it gives us a high-signal
source of information to query for the security products installed on the
system. I've tied this query into the osdiag package and is run during
bugreports.

It uses COM bindings that were automatically generated by my prototype
metadata processor, however that program still has a few bugs, so I had
to make a few manual tweaks. I dropped those binding into an internal
package because (for the moment, at least) they are effectively
purpose-built for the osdiag use case.

We also update the wingoes dependency to pick up BSTR.

Fixes #10646

Signed-off-by: Aaron Klotz <aaron@tailscale.com>
2 years ago