tailscale

Commit Graph

Author	SHA1	Message	Date
Andrew Lytvynov	2716250ee8	all: cleanup unused code, part 2 (#10670 ) And enable U1000 check in staticcheck. Updates #cleanup Signed-off-by: Andrew Lytvynov <awly@tailscale.com>	11 months ago
Marwan Sulaiman	e32e5c0d0c	portlist: add Poller.IncludeLocalhost option This PR parameterizes receiving loopback updates from the portlist package. Callers can now include services bound to localhost if they want. Note that this option is off by default still. Fixes #8171 Signed-off-by: Marwan Sulaiman <marwan@tailscale.com>	2 years ago
Will Norris	71029cea2d	all: update copyright and license headers This updates all source files to use a new standard header for copyright and license declaration. Notably, copyright no longer includes a date, and we now use the standard SPDX-License-Identifier header. This commit was done almost entirely mechanically with perl, and then some minimal manual fixes. Updates #6865 Signed-off-by: Will Norris <will@tailscale.com>	2 years ago
Brad Fitzpatrick	21ef7e5c35	portlist: add macOS osImpl, finish migration to new style Previously: * `036f70b7b4` for linux * `35bee36549` for windows This does macOS. And removes all the compat code for the old style. (e.g. iOS, js are no longer mentioned; all platforms without implementations just default to not doing anything) One possible regression is that platforms without explicit implementations previously tried to do the "netstat -na" style to get open ports (but not process names). Maybe that worked on FreeBSD and OpenBSD previously, but nobody ever really tested it. And it was kinda useless without associated process names. So better off removing those for now until they get a good implementation. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	2 years ago
Brad Fitzpatrick	da8def8e13	all: remove old +build tags The //go:build syntax was introduced in Go 1.17: https://go.dev/doc/go1.17#build-lines gofmt has kept the +build and go:build lines in sync since then, but enough time has passed. Time to remove them. Done with: perl -i -npe 's,^// \+build.*\n,,' $(git grep -l -F '+build') Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	2 years ago
Brad Fitzpatrick	46ce80758d	portlist: update some internals to use append-style APIs In prep for reducing garbage, being able to reuse memory. So far this doesn't actually reuse much. This is just changing signatures around. But some improvement in any case: bradfitz@tsdev:~/src/tailscale.com$ ~/go/bin/benchstat before after name old time/op new time/op delta GetList-8 11.8ms ± 9% 9.9ms ± 3% -15.98% (p=0.000 n=10+10) name old alloc/op new alloc/op delta GetList-8 99.5kB ± 2% 91.9kB ± 0% -7.62% (p=0.000 n=9+9) name old allocs/op new allocs/op delta GetList-8 3.05k ± 1% 2.93k ± 0% -3.83% (p=0.000 n=8+9) More later, once parsers can reuse strings from previous parses. Updates #5958 Change-Id: I76cd5048246dd24d11c4e263d8bb8041747fb2b0 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	2 years ago
Mihai Parparita	27a1ad6a70	wasm: exclude code that's not used on iOS for Wasm too It has similar size constraints. Saves ~1.9MB from the Wasm build. Updates #3157 Signed-off-by: Mihai Parparita <mihai@tailscale.com>	2 years ago
Josh Bleecher Snyder	6da6d47a83	all: simplify build tags involving iOS Prior to Go 1.16, iOS used GOOS=darwin, so we had to distinguish macOS from iOS during GOARCH. We now require Go 1.16 in our go.mod, so we can simplify. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Josh Bleecher Snyder	a5da4ed981	all: gofmt with Go 1.17 This adds "//go:build" lines and tidies up existing "// +build" lines. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Brad Fitzpatrick	e619296ece	portlist: filter out all of 127.0.0.0/8, not just 127.0.0.1/32 Per user private bug report. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	f325aa7e38	portlist: exclude services bound to IPv6 loopback address Fixes #1683 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
David Anderson	ad6edf5ecd	portlist: report a better process name for .Net on linux. Fixes #1440. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
moncho	e101d8396d	portlist, version: update build tags for Go 1.16, Apple M1 Build tags have been updated to build native Apple M1 binaries, existing build tags for ios have been changed from darwin,arm64 to ios,arm64. With this change, running go build cmd/tailscale{,d}/tailscale{,d}.go on an Apple machine with the new processor works and resulting binaries show the expected architecture, e.g. tailscale: Mach-O 64-bit executable arm64. Tested using go version go1.16beta1 darwin/arm64. Updates #943 Signed-off-by: moncho <50428+moncho@users.noreply.github.com>	4 years ago
Josh Bleecher Snyder	a570c27577	portlist: reduce log spam on macOS Running tailscaled on my machine yields lots of entries like: weird: missing {tcp 6060} parsePortsNetstat is filtering out loopback addresses as uninteresting. Then addProcesses is surprised to discover these listening ports, which results in spurious logging. Teach addProcesses to also ignore loopback addresses. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
David Anderson	9396024bd7	portlist: move code around to avoid unused function warnings.	5 years ago
Brad Fitzpatrick	2776209e49	portlist: don't depend on osexec package on ios, even if it's unused Continuation of `5bb14c07dc`. The earlier commit provided the space savings (as the linker could see through that osexec was unused at runtime), but it didn't clean up the dep graph (from go list -json or godepgraph). This removes the netstat.go file from the build too, just so the dep list looks more reasonable.	5 years ago
Brad Fitzpatrick	f8d67bb591	portlist: ignore ports bound to localhost Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Anderson	9ac1dda0d9	portlist: add a lint ignore for unused function. The function is indeed unused on linux, but we want it around so that unit tests exercise the netstat logic even on linux, even if it's only used on !linux. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Anderson	520e96afd1	portlist: simplify slice expression. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
Earl Lee	a8d8b8719a	Move Linux client & common packages into a public repo.	5 years ago

20 Commits (1bd1d053349f53ac8c27e8afb268ab2c42e1e7bc)