8385 Commits (main)

 

All Branches   

Search

Author	SHA1	Message	Date
David Anderson	bc20e555c5	Print the staticcheck version. ... Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
Brad Fitzpatrick	a9cd8f31de	tsweb: don't double import expvar; appease staticcheck	5 years ago
Brad Fitzpatrick	890f5dff40	tsweb: export runtime.MemStats var in Prometheus format	5 years ago
Brad Fitzpatrick	8abdbbdd1f	cmd/derper: also link to /debug/varz	5 years ago
David Anderson	905fe9f6a2	update CI and everything to Go 1.14.	5 years ago
David Anderson	c8ebac2def	wgengine/magicsock: try deflaking again. ... This change just alters the semantics of the one flaky test, without trying to speed up timeouts on the others. Empirically, speeding up the timeouts causes _more_ flakes right now :(	5 years ago
David Anderson	cd1ac63b4c	Revert "wgengine/magicsock: temporarily deflake." ... This reverts commit c5835c6ced.	5 years ago
David Anderson	c5835c6ced	wgengine/magicsock: temporarily deflake. ... The remaining flake occurs due to a mysterious packet loss. This doesn't affect normal tailscaled operations, so until I track down where the loss occurs and fix it, the flaky test is going to be lenient about packet loss (but not about whether the spray logic worked). Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
Brad Fitzpatrick	946df89fa6	types/logger: add adapters for Logf to std Logger/Writer	5 years ago
David Crawshaw	5562fae9f0	ipn: use NewPrefs in e2e_test ... We weren't setting UsePacketFilter, so the synthetic ping packets used to establish a connection were never being sent. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	61d83f759b	wgengine/magicsock: remove redundant derpMagicIP comparison ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Anderson	bd60a750e8	wgengine/magicsock: fix packet spraying test to (mostly) pass. ... It previously passed incorrectly due to bugs. With those fixed, it becomes flaky for 2 reasons. One of them is the wireguard handshake race, which can eat the 1st sprayed packet and prevent roamAddr discovery. This change fixes that failure, by spreading the test traffic out enough that additional spraying occurs. Signed-Off-By: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	ef31dd7bb5	wgengine/magicsock: check all 3 fast paths independently. ... The previous code would skip the DERP short-circuit if roamAddr was set, which is not what we wanted. More generally, hitting any of the fast path conditions is a direct return, so we can just have 3 standalone branches rather than 'else if' stuff. Signed-Off-By: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	05a52746a4	wgengine/magicsock: fix destination selection logic to work with DERP. ... The effect is subtle: when we're not spraying packets, and have not yet figured out a curAddr, and we're not spraying, we end up sending to whatever the first IP is in the iteration order. In English, that means "when we have no idea where to send packets, and we've given up on sending to everyone, just send to the first addr we see in the list." This is, in general, what we want, because the addrs are in sorted preference order, low to high, and DERP is the least preferred destination. So, when we have no idea where to send, send to DERP, right? ... Except for very historical reasons, appendDests iterated through addresses in _reverse_ order, most preferred to least preferred. crawshaw@ believes this was part of the earliest handshaking algorithm magicsock had, where it slowly iterated through possible destinations and poked handshakes to them one at a time. Anyway, because of this historical reverse iteration, in the case described above of "we have no idea where to send", the code would end up sending to the _most_ preferred candidate address, rather than the _least_ preferred. So when in doubt, we'd end up firing packets into the blackhole of some LAN address that doesn't work, and connectivity would not work. This case only comes up if all your non-DERP connectivity options have failed, so we more or less failed to detect it because we didn't have a pathological test box deployed. Worse, codependent bug 2839854994 made DERP accidentally work sometimes anyway by incorrectly exploiting roamAddr behavior, albeit at the cost of making DERP traffic symmetric. In fixing DERP to once again be asymmetric, we effectively removed the bandaid that was concealing this bug. Signed-Off-By: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	97e58ad44d	wgengine/magicsock: only set addrByKey once in CreateEndpoint. ... Signed-Off-By: David Anderson <danderson@tailscale.com>	5 years ago
Brad Fitzpatrick	fbab12c94c	wgengine/magicsock: skip netcheck if external STUN aren't in use ... Updates #146 (not a complete fix yet probably)	5 years ago
Brad Fitzpatrick	fe0051fafd	wgengine/magicsock: expand AddrSet.addrs comment	5 years ago
Brad Fitzpatrick	e733fa6f7e	derp: add some varz tests for active/home conns	5 years ago
Brad Fitzpatrick	dd456f04c5	derp: actually record client's preferred bit	5 years ago
David Anderson	2839854994	wgengine/magicsock: never set a DERP server as a roamAddr. ... DERP traffic is asymmetric by design, with nodes always sending to their peer's home DERP server. However, if roamAddr is set, magicsock will always push data there, rather than let DERP server selection do its thing, so we end up accidentally creating a symmetric flow. Signed-Off-By: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	4f5c0da1ae	wgengine/magicsock: log when home DERP server changes.	5 years ago
Brad Fitzpatrick	61f3fda405	tsweb: let expvar.Ints be gauges too	5 years ago
Brad Fitzpatrick	6978b93bdd	derp, magicsock: track home (preferred) vs visiting connections for stats	5 years ago
Brad Fitzpatrick	12b77f30ad	wgengine/magicsock: close stale DERP connections	5 years ago
Brad Fitzpatrick	cf4aacde57	derp/derphttp: appease staticcheck	5 years ago
Brad Fitzpatrick	2cff9016e4	net/dnscache: add overly simplistic DNS cache package for selective use ... I started to write a full DNS caching resolver and I realized it was overkill and wouldn't work on Windows even in Go 1.14 yet, so I'm doing this tiny one instead for now, just for all our netcheck STUN derp lookups, and connections to DERP servers. (This will be caching a exactly 8 DNS entries, all ours.) Fixes #145 (can be better later, of course)	5 years ago
Brad Fitzpatrick	a36ccb8525	wgengine/magicsock: actually add to the activeDerp map ... Fixes bug just introduced in 8f9849c140; not tested enough :(	5 years ago
Brad Fitzpatrick	8f9849c140	wgengine/magicsock: collapse three DERP maps down into one	5 years ago
Brad Fitzpatrick	7e1bed82bd	go.sum: update	5 years ago
Brad Fitzpatrick	40ebba1373	magicsock: use [unexpected] convention more ... Fixes #136 (not entirely, but we have a convention now)	5 years ago
Brad Fitzpatrick	848a2bddf0	wgengine/magicsock: update set of DERP nodes	5 years ago
David Crawshaw	551964c562	go.mod: update wireguard-go version ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	4a7638c319	go.mod: update wireguard-go version ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	7932481b95	magicsock: lookup AddrSet by key from DERP ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	57de94c7aa	tsweb: add /debug/ access via &debugkey + TS_DEBUG_KEY_PATH	5 years ago
David Anderson	d580157921	tsweb: quote label values to comply with Prometheus format.	5 years ago
Brad Fitzpatrick	ff6b3c2c38	netcheck: include two more DERP nodes, show more in CLI report	5 years ago
David Anderson	f192c05413	metrics: add a LabelMap type for variables with 1 label dimension. ... This lets us publish sets of vars that are breakdowns along one dimension in a format that Prometheus and Grafana natively know how to do useful things with. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
Brad Fitzpatrick	eac62ec5ff	ipn, wgengine/magicsock: add ipn.Prefs.DisableDERP bool ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	bf704a5218	derp: protocol negotiation, add v2: send src pub keys to clients in packets ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Crawshaw	a65b2a0efd	magicsock: add some DERP tests ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	a33419167b	magicsock: plumb through derpTLSConfig variable (for testing) ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	9be9738f62	derphttp: add TLSConfig field ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	caec2c7e8b	magicsock: test sequence of pings ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	9f584414d9	magicsock: simple ping test via magicsock ... Passes `go test -count=20 -race ./wgengine/magicsock` Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	34859f8e7d	wgengine, magicsock: add a CreateBind method ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	75e62d318f	magicsock: use local STUN server in tests ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	596fd449b9	netcheck: add TODO about alternate timing strategies	5 years ago
Brad Fitzpatrick	b27d4c017a	magicsock, wgengine, ipn, controlclient: plumb regular netchecks to map poll ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	4cf5ac3060	ipn/ipnserver: remove unnecessary closure parameter	5 years ago