From dba9b969084027c8ac02b8a21648109ddab673cc Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Thu, 9 Jul 2020 14:38:23 -0700 Subject: [PATCH] version: remove quoting around version name I added them earlier while fighting our redo+xcode build which wasn't picking up these files on incremental builds. It still isn't, but now I've verified with full builds that no quotes is correct. --- version/mkversion.sh | 2 +- version/mkversion_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/version/mkversion.sh b/version/mkversion.sh index cafaf858e..b28f50e4b 100755 --- a/version/mkversion.sh +++ b/version/mkversion.sh @@ -77,7 +77,7 @@ xcode() { # CFBundleShortVersionString: the "short name" used in the App Store. # e.g. 0.92.98 - echo "VERSION_NAME = \"$name\"" + echo "VERSION_NAME = $name" # CFBundleVersion: the build number. Needs to be 3 numeric sections # that increment for each release according to SemVer rules. # diff --git a/version/mkversion_test.go b/version/mkversion_test.go index f693a80d6..5837a7bc3 100644 --- a/version/mkversion_test.go +++ b/version/mkversion_test.go @@ -12,7 +12,7 @@ import ( ) func xcode(name, semver string) string { - return fmt.Sprintf("VERSION_NAME = %q\nVERSION_ID = %s", name, semver) + return fmt.Sprintf("VERSION_NAME = %s\nVERSION_ID = %s", name, semver) } func mkversion(t *testing.T, mode, in string) string {