From d5a0a4297e55adf77d7585f16caeae62c6d16cae Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Thu, 16 Sep 2021 16:31:35 -0700 Subject: [PATCH] cmd/cloner: unify switch cases And in the process, fix a bug: The fmt formatting was being applied by writef, not fmt.Sprintf, thus emitting a MISSING string. And there's no guarantee that fmt will be imported in the generated code. Signed-off-by: Josh Bleecher Snyder --- cmd/cloner/cloner.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cmd/cloner/cloner.go b/cmd/cloner/cloner.go index 1bc4dfbe1..421f0e69c 100644 --- a/cmd/cloner/cloner.go +++ b/cmd/cloner/cloner.go @@ -211,10 +211,8 @@ func gen(buf *bytes.Buffer, imports map[string]struct{}, typ *types.Named, thisP writef("\t}") } writef("}") - case *types.Struct: - writef(`panic("TODO struct %s")`, fname) default: - writef(`panic(fmt.Sprintf("TODO: %T", ft))`) + writef(`panic("TODO: %s (%T)")`, fname, ft) } } writef("return dst")