From d4122c9f0a1ed9dd75385358e58df1ea37d77031 Mon Sep 17 00:00:00 2001
From: Jordan Whited <jordan@tailscale.com>
Date: Fri, 24 Feb 2023 15:26:23 -0800
Subject: [PATCH] cmd/tailscale/cli: fix TestUpdatePrefs over Tailscale SSH
 (#7374)

Fixes #7373

Signed-off-by: Jordan Whited <jordan@tailscale.com>
---
 cmd/tailscale/cli/cli_test.go | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/cmd/tailscale/cli/cli_test.go b/cmd/tailscale/cli/cli_test.go
index 623cb2c34..cf21d4885 100644
--- a/cmd/tailscale/cli/cli_test.go
+++ b/cmd/tailscale/cli/cli_test.go
@@ -1078,6 +1078,13 @@ func TestUpdatePrefs(t *testing.T) {
 				old := getSSHClientEnvVar
 				getSSHClientEnvVar = func() string { return "100.100.100.100 1 1" }
 				t.Cleanup(func() { getSSHClientEnvVar = old })
+			} else if isSSHOverTailscale() {
+				// The test is being executed over a "real" tailscale SSH
+				// session, but sshOverTailscale is unset. Make the test appear
+				// as if it's not over tailscale SSH.
+				old := getSSHClientEnvVar
+				getSSHClientEnvVar = func() string { return "" }
+				t.Cleanup(func() { getSSHClientEnvVar = old })
 			}
 			if tt.env.goos == "" {
 				tt.env.goos = "linux"