From d3ba860ffd6082dff79315f989e271df6a61f31a Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Tue, 4 May 2021 09:24:52 -0700 Subject: [PATCH] syncs: stop running TestWatchMultipleValues on CI It's flaky, and not just on Windows. Signed-off-by: Josh Bleecher Snyder --- syncs/watchdog_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/syncs/watchdog_test.go b/syncs/watchdog_test.go index 116d00625..07b03283a 100644 --- a/syncs/watchdog_test.go +++ b/syncs/watchdog_test.go @@ -6,7 +6,6 @@ package syncs import ( "context" - "runtime" "sync" "testing" "time" @@ -49,11 +48,11 @@ func TestWatchContended(t *testing.T) { } func TestWatchMultipleValues(t *testing.T) { - if cibuild.On() && runtime.GOOS == "windows" { + if cibuild.On() { // On the CI machine, it sometimes takes 500ms to start a new goroutine. // When this happens, we don't get enough events quickly enough. // Nothing's wrong, and it's not worth working around. Just skip the test. - t.Skip("flaky on Windows CI") + t.Skip("flaky on CI") } mu := new(sync.Mutex) ctx, cancel := context.WithCancel(context.Background())