From be3ca5cbfd769e426cb0a97e780b4d0a92c0e1bc Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Sat, 25 Jul 2020 19:36:39 -0700 Subject: [PATCH] control/controlclient: remove unused, slow, often-not-what-you-want NetworkMap.Equal --- control/controlclient/netmap.go | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/control/controlclient/netmap.go b/control/controlclient/netmap.go index 37e9a171e..66017e6ff 100644 --- a/control/controlclient/netmap.go +++ b/control/controlclient/netmap.go @@ -5,7 +5,6 @@ package controlclient import ( - "bytes" "encoding/json" "fmt" "log" @@ -55,26 +54,6 @@ type NetworkMap struct { // TODO(crawshaw): Capabilities []tailcfg.Capability } -func (n *NetworkMap) Equal(n2 *NetworkMap) bool { - if n == nil && n2 == nil { - return true - } - if n == nil || n2 == nil { - return false - } - - // TODO(crawshaw): this is crude, but is an easy way to avoid bugs. - b, err := json.Marshal(n) - if err != nil { - panic(err) - } - b2, err := json.Marshal(n2) - if err != nil { - panic(err) - } - return bytes.Equal(b, b2) -} - func (nm NetworkMap) String() string { return nm.Concise() }