From bbca2c78cbd07704b2921e0a8598f87619dbc3af Mon Sep 17 00:00:00 2001
From: Maisem Ali <maisem@tailscale.com>
Date: Fri, 22 Apr 2022 23:22:00 -0700
Subject: [PATCH] tsnet: fix mem.Store check for normal nodes

There was a typo in the check it was doing `!ok` instead of `ok`, this
restructures it a bit to read better.

Fixes #4506

Signed-off-by: Maisem Ali <maisem@tailscale.com>
---
 tsnet/tsnet.go | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tsnet/tsnet.go b/tsnet/tsnet.go
index 909823dde..ae6b5c4b0 100644
--- a/tsnet/tsnet.go
+++ b/tsnet/tsnet.go
@@ -137,8 +137,9 @@ func (s *Server) start() error {
 	}
 
 	s.rootPath = s.Dir
-	if s.Store != nil && !s.Ephemeral {
-		if _, ok := s.Store.(*mem.Store); !ok {
+	if s.Store != nil {
+		_, isMemStore := s.Store.(*mem.Store)
+		if isMemStore && !s.Ephemeral {
 			return fmt.Errorf("in-memory store is only supported for Ephemeral nodes")
 		}
 	}