From b64d900f0ffb56a176dcce62cb1363bcbdc8b4f0 Mon Sep 17 00:00:00 2001 From: David Anderson Date: Fri, 10 Feb 2023 21:52:58 -0800 Subject: [PATCH] version: fix version output for "go run" Before (note attempted use of absent date and commit hash): "short": "1.37.0-dev", "long": "1.37.0-dev-t", After: "short": "1.37.0-ERR-BuildInfo", "long": "1.37.0-ERR-BuildInfo", Signed-off-by: David Anderson --- version/version.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/version/version.go b/version/version.go index 17a74a338..98e3892e6 100644 --- a/version/version.go +++ b/version/version.go @@ -134,6 +134,11 @@ var getEmbeddedInfo = lazy.SyncFunc(func() embeddedInfo { ret.dirty = true } } + if ret.commit == "" || ret.commitDate == "" { + // Build info is present in the binary, but has no useful data. Act as + // if it's missing. + return embeddedInfo{} + } return ret })