From b340beff8ed058988729009c63c48d320959aa7b Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Mon, 24 May 2021 14:41:58 -0700 Subject: [PATCH] internal/deephash: reset scratch before appending to it Oops. In practice this doesn't matter, but it's still wrong. Signed-off-by: Josh Bleecher Snyder --- internal/deephash/deephash.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/deephash/deephash.go b/internal/deephash/deephash.go index 630eddacc..c360b5b78 100644 --- a/internal/deephash/deephash.go +++ b/internal/deephash/deephash.go @@ -156,7 +156,7 @@ func print(w *bufio.Writer, v reflect.Value, visited map[uintptr]bool, scratch [ case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64: fmt.Fprintf(w, "%v", v.Int()) case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr: - scratch = strconv.AppendUint(scratch, v.Uint(), 10) + scratch = strconv.AppendUint(scratch[:0], v.Uint(), 10) w.Write(scratch) case reflect.Float32, reflect.Float64: fmt.Fprintf(w, "%v", v.Float())