From b090d61c0fbe74636b3efb9a6f76e76c1dd96eb7 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Wed, 16 Aug 2023 15:27:33 -0700 Subject: [PATCH] tailcfg: rename prototype field to reflect its status (Added earlier today in #8916, 57da1f150) Updates tailscale/corp#13969 Signed-off-by: Brad Fitzpatrick --- client/tailscale/apitype/controltype.go | 14 +++++++------- tailcfg/tailcfg.go | 7 +++++-- tailcfg/tailcfg_clone.go | 2 +- tailcfg/tailcfg_view.go | 4 ++-- 4 files changed, 15 insertions(+), 12 deletions(-) diff --git a/client/tailscale/apitype/controltype.go b/client/tailscale/apitype/controltype.go index bca4b178e..9a623be31 100644 --- a/client/tailscale/apitype/controltype.go +++ b/client/tailscale/apitype/controltype.go @@ -4,13 +4,13 @@ package apitype type DNSConfig struct { - Resolvers []DNSResolver `json:"resolvers"` - FallbackResolvers []DNSResolver `json:"fallbackResolvers"` - Routes map[string][]DNSResolver `json:"routes"` - Domains []string `json:"domains"` - Nameservers []string `json:"nameservers"` - Proxied bool `json:"proxied"` - DNSFilterURL string `json:"DNSFilterURL"` + Resolvers []DNSResolver `json:"resolvers"` + FallbackResolvers []DNSResolver `json:"fallbackResolvers"` + Routes map[string][]DNSResolver `json:"routes"` + Domains []string `json:"domains"` + Nameservers []string `json:"nameservers"` + Proxied bool `json:"proxied"` + TempCorpIssue13969 string `json:"TempCorpIssue13969,omitempty"` } type DNSResolver struct { diff --git a/tailcfg/tailcfg.go b/tailcfg/tailcfg.go index abc23834c..20a3fb6bf 100644 --- a/tailcfg/tailcfg.go +++ b/tailcfg/tailcfg.go @@ -1403,8 +1403,11 @@ type DNSConfig struct { // // Matches are case insensitive. ExitNodeFilteredSet []string `json:",omitempty"` - // DNSFilterURL contains a user inputed URL that should have a list of domains to be blocked - DNSFilterURL string `json:",omitempty"` + + // TempCorpIssue13969 is a temporary (2023-08-16) field for an internal hack day prototype. + // It contains a user inputed URL that should have a list of domains to be blocked. + // See https://github.com/tailscale/corp/issues/13969. + TempCorpIssue13969 string `json:",omitempty"` } // DNSRecord is an extra DNS record to add to MagicDNS. diff --git a/tailcfg/tailcfg_clone.go b/tailcfg/tailcfg_clone.go index 60978e41d..8ba9d49fa 100644 --- a/tailcfg/tailcfg_clone.go +++ b/tailcfg/tailcfg_clone.go @@ -261,7 +261,7 @@ var _DNSConfigCloneNeedsRegeneration = DNSConfig(struct { CertDomains []string ExtraRecords []DNSRecord ExitNodeFilteredSet []string - DNSFilterURL string + TempCorpIssue13969 string }{}) // Clone makes a deep copy of RegisterResponse. diff --git a/tailcfg/tailcfg_view.go b/tailcfg/tailcfg_view.go index 3c915f9f0..3ed6f6b7e 100644 --- a/tailcfg/tailcfg_view.go +++ b/tailcfg/tailcfg_view.go @@ -557,7 +557,7 @@ func (v DNSConfigView) ExtraRecords() views.Slice[DNSRecord] { return views.Slic func (v DNSConfigView) ExitNodeFilteredSet() views.Slice[string] { return views.SliceOf(v.ж.ExitNodeFilteredSet) } -func (v DNSConfigView) DNSFilterURL() string { return v.ж.DNSFilterURL } +func (v DNSConfigView) TempCorpIssue13969() string { return v.ж.TempCorpIssue13969 } // A compilation failure here means this code must be regenerated, with the command at the top of this file. var _DNSConfigViewNeedsRegeneration = DNSConfig(struct { @@ -570,7 +570,7 @@ var _DNSConfigViewNeedsRegeneration = DNSConfig(struct { CertDomains []string ExtraRecords []DNSRecord ExitNodeFilteredSet []string - DNSFilterURL string + TempCorpIssue13969 string }{}) // View returns a readonly view of RegisterResponse.