From a722e48cef1beb434afd1c83cc9097efd8b5fe7d Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Wed, 15 Sep 2021 16:43:44 -0700 Subject: [PATCH] wgengine/magicsock: skip alloc test with -race Signed-off-by: Josh Bleecher Snyder --- wgengine/magicsock/magicsock_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/wgengine/magicsock/magicsock_test.go b/wgengine/magicsock/magicsock_test.go index 431e288e9..ba4828ee1 100644 --- a/wgengine/magicsock/magicsock_test.go +++ b/wgengine/magicsock/magicsock_test.go @@ -42,6 +42,7 @@ import ( "tailscale.com/types/nettype" "tailscale.com/types/wgkey" "tailscale.com/util/cibuild" + "tailscale.com/util/racebuild" "tailscale.com/wgengine/filter" "tailscale.com/wgengine/wgcfg" "tailscale.com/wgengine/wgcfg/nmcfg" @@ -1261,6 +1262,9 @@ func TestGoMajorVersion(t *testing.T) { } func TestReceiveFromAllocs(t *testing.T) { + if racebuild.On { + t.Skip("alloc tests are unreliable with -race") + } // Go 1.16 and before: allow 3 allocs. // Go Tailscale fork, Go 1.17+: only allow 2 allocs. major, ts := goMajorVersion(runtime.Version())