From 96f73b38946f5acc09ee8718171054155ebda32d Mon Sep 17 00:00:00 2001
From: Joe Tsai <joetsai@digital-static.net>
Date: Tue, 7 Jun 2022 17:25:05 -0700
Subject: [PATCH] logtail: do not panic in PrivateID.PublicID (#4815)

It is not idiomatic for Go code to panic for situations that
can be normal. For example, if a server receives PrivateID
from a client, it is normal for the server to call
PrivateID.PublicID to validate that the PublicID matches.
However, doing so would panic prior to this change.

Signed-off-by: Joe Tsai <joetsai@digital-static.net>
---
 logtail/id.go | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/logtail/id.go b/logtail/id.go
index 596634d19..32727f213 100644
--- a/logtail/id.go
+++ b/logtail/id.go
@@ -80,10 +80,6 @@ func (id PrivateID) String() string {
 }
 
 func (id PrivateID) Public() (pub PublicID) {
-	var emptyID PrivateID
-	if id == emptyID {
-		panic("invalid logtail.Public() on an empty private ID")
-	}
 	h := sha256.New()
 	h.Write(id[:])
 	if n := copy(pub[:], h.Sum(pub[:0])); n != len(pub) {