From 8de7f9bff7eb03fc1368776b68cb40bff0d208e9 Mon Sep 17 00:00:00 2001 From: James Tucker Date: Mon, 28 Mar 2022 18:11:04 -0700 Subject: [PATCH] tailscaled: no longer tune gcpercent Usage of userspace-networking is increasing, and the aggressive GC tuning causes a significant reduction in performance in that mode. Signed-off-by: James Tucker --- cmd/tailscaled/tailscaled.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/cmd/tailscaled/tailscaled.go b/cmd/tailscaled/tailscaled.go index 8a88fd338..94ee56085 100644 --- a/cmd/tailscaled/tailscaled.go +++ b/cmd/tailscaled/tailscaled.go @@ -25,7 +25,6 @@ import ( "os/signal" "path/filepath" "runtime" - "runtime/debug" "strings" "syscall" "time" @@ -130,14 +129,6 @@ var subCommands = map[string]*func([]string) error{ } func main() { - // We aren't very performance sensitive, and the parts that are - // performance sensitive (wireguard) try hard not to do any memory - // allocations. So let's be aggressive about garbage collection, - // unless the user specifically overrides it in the usual way. - if _, ok := os.LookupEnv("GOGC"); !ok { - debug.SetGCPercent(10) - } - printVersion := false flag.IntVar(&args.verbose, "verbose", 0, "log verbosity level; 0 is default, 1 or higher are increasingly verbose") flag.BoolVar(&args.cleanup, "cleanup", false, "clean up system state and exit")