From 8b80d63b423bb66da379fa25949c0d3a704afdb4 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Thu, 22 Jun 2023 08:09:27 -0700 Subject: [PATCH] wgengine/magicsock: clarify a log message is a warning, not an error Updates #cleanup Signed-off-by: Brad Fitzpatrick --- wgengine/magicsock/magicsock_linux.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wgengine/magicsock/magicsock_linux.go b/wgengine/magicsock/magicsock_linux.go index cdfbeb759..a4101ccba 100644 --- a/wgengine/magicsock/magicsock_linux.go +++ b/wgengine/magicsock/magicsock_linux.go @@ -303,11 +303,11 @@ func trySetSocketBuffer(pconn nettype.PacketConn, logf logger.Logf) { rc.Control(func(fd uintptr) { errRcv = syscall.SetsockoptInt(int(fd), syscall.SOL_SOCKET, syscall.SO_RCVBUFFORCE, socketBufferSize) if errRcv != nil { - logf("magicsock: failed to force-set UDP read buffer size to %d: %v", socketBufferSize, errRcv) + logf("magicsock: [warning] failed to force-set UDP read buffer size to %d: %v; using kernel default values (impacts throughput only)", socketBufferSize, errRcv) } errSnd = syscall.SetsockoptInt(int(fd), syscall.SOL_SOCKET, syscall.SO_SNDBUFFORCE, socketBufferSize) if errSnd != nil { - logf("magicsock: failed to force-set UDP write buffer size to %d: %v", socketBufferSize, errSnd) + logf("magicsock: [warning] failed to force-set UDP write buffer size to %d: %v; using kernel default values (impacts throughput only)", socketBufferSize, errSnd) } }) }