From 7558a1d5940f16ec560df07babb2480f9ef5abee Mon Sep 17 00:00:00 2001 From: James Tucker Date: Mon, 1 Apr 2024 14:17:09 -0700 Subject: [PATCH] ipn/ipnlocal: disable sockstats on (unstable) mobile by default We're tracking down a new instance of memory usage, and excessive memory usage from sockstats is definitely not going to help with debugging, so disable it by default on mobile. Updates tailscale/corp#18514 Signed-off-by: James Tucker --- ipn/ipnlocal/local.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ipn/ipnlocal/local.go b/ipn/ipnlocal/local.go index 625c76379..77982eb31 100644 --- a/ipn/ipnlocal/local.go +++ b/ipn/ipnlocal/local.go @@ -405,8 +405,8 @@ func NewLocalBackend(logf logger.Logf, logID logid.PublicID, sys *tsd.System, lo if err != nil { log.Printf("error setting up sockstat logger: %v", err) } - // Enable sockstats logs only on unstable builds - if version.IsUnstableBuild() && b.sockstatLogger != nil { + // Enable sockstats logs only on non-mobile unstable builds + if version.IsUnstableBuild() && !version.IsMobile() && b.sockstatLogger != nil { b.sockstatLogger.SetLoggingEnabled(true) }