From 6f590f5b528a99e703b484c18d30d0194c06401c Mon Sep 17 00:00:00 2001 From: Avery Pennarun Date: Fri, 5 Jun 2020 03:06:29 -0400 Subject: [PATCH] logtail: we missed a case for the backoff timer. We want to run bo.Backoff() after every upload, regardless. If upload==true but err!=nil, we weren't backing off, which caused some very-high-throughput log upload retries in bad network conditions. Updates #282. Signed-off-by: Avery Pennarun --- logtail/logtail.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/logtail/logtail.go b/logtail/logtail.go index 169897f54..69411926b 100644 --- a/logtail/logtail.go +++ b/logtail/logtail.go @@ -273,10 +273,10 @@ func (l *logger) uploading(ctx context.Context) { if err != nil { fmt.Fprintf(l.stderr, "logtail: upload: %v\n", err) } + l.bo.BackOff(ctx, err) if uploaded { break } - l.bo.BackOff(ctx, err) } select {