From 68d9d161f4da3b5dd5a8402196bfe33eff1a6bd6 Mon Sep 17 00:00:00 2001 From: Maisem Ali Date: Mon, 29 Aug 2022 15:16:34 -0700 Subject: [PATCH] net/dns: [win] fix regression in disableDynamicUpdate Somehow I accidentally set the wrong registry value here. It should be DisableDynamicUpdate=1 and not EnableDNSUpdate=0. This is a regression from 545639e. Signed-off-by: Maisem Ali --- net/dns/manager_windows.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/dns/manager_windows.go b/net/dns/manager_windows.go index 843ab22ed..6760a85e8 100644 --- a/net/dns/manager_windows.go +++ b/net/dns/manager_windows.go @@ -388,10 +388,10 @@ func (m windowsManager) Close() error { // Windows DHCP client from sending dynamic DNS updates for our interface to // AD domain controllers. func (m windowsManager) disableDynamicUpdates() error { - if err := m.setSingleDWORD(winutil.IPv4TCPIPInterfacePrefix, "EnableDNSUpdate", 0); err != nil { + if err := m.setSingleDWORD(winutil.IPv4TCPIPInterfacePrefix, "DisableDynamicUpdate", 1); err != nil { return err } - if err := m.setSingleDWORD(winutil.IPv6TCPIPInterfacePrefix, "EnableDNSUpdate", 0); err != nil { + if err := m.setSingleDWORD(winutil.IPv6TCPIPInterfacePrefix, "DisableDynamicUpdate", 1); err != nil { return err } return nil