From 43f7ec48cad15e63b3caee18bd0d415b5df859a3 Mon Sep 17 00:00:00 2001 From: shayne Date: Mon, 27 Mar 2023 10:12:32 -0400 Subject: [PATCH] funnel: change references from alpha to beta (#7613) Updates CLI and docs to reference Funnel as beta Signed-off-by: Shayne Sweeney --- cmd/tailscale/cli/funnel.go | 2 +- cmd/tailscale/cli/serve.go | 4 ++-- ipn/serve.go | 4 ++-- tailcfg/tailcfg.go | 3 ++- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/cmd/tailscale/cli/funnel.go b/cmd/tailscale/cli/funnel.go index 5532f05fa..ad89d9078 100644 --- a/cmd/tailscale/cli/funnel.go +++ b/cmd/tailscale/cli/funnel.go @@ -29,7 +29,7 @@ var funnelCmd = newFunnelCommand(&serveEnv{lc: &localClient}) func newFunnelCommand(e *serveEnv) *ffcli.Command { return &ffcli.Command{ Name: "funnel", - ShortHelp: "[ALPHA] turn Tailscale Funnel on or off", + ShortHelp: "[BETA] turn Tailscale Funnel on or off", ShortUsage: strings.TrimSpace(` funnel {on|off} funnel status [--json] diff --git a/cmd/tailscale/cli/serve.go b/cmd/tailscale/cli/serve.go index 9ef67cf46..acd073679 100644 --- a/cmd/tailscale/cli/serve.go +++ b/cmd/tailscale/cli/serve.go @@ -33,7 +33,7 @@ var serveCmd = newServeCommand(&serveEnv{lc: &localClient}) func newServeCommand(e *serveEnv) *ffcli.Command { return &ffcli.Command{ Name: "serve", - ShortHelp: "[ALPHA] Serve from your Tailscale node", + ShortHelp: "[BETA] Serve from your Tailscale node", ShortUsage: strings.TrimSpace(` serve https: [off] serve tcp: tcp://localhost: [off] @@ -41,7 +41,7 @@ serve https: [off] serve status [--json] `), LongHelp: strings.TrimSpace(` -*** ALPHA; all of this is subject to change *** +*** BETA; all of this is subject to change *** The 'tailscale serve' set of commands allows you to serve content and local servers from your Tailscale node to diff --git a/ipn/serve.go b/ipn/serve.go index c0ba3b669..701c32f57 100644 --- a/ipn/serve.go +++ b/ipn/serve.go @@ -180,7 +180,7 @@ func (sc *ServeConfig) IsFunnelOn() bool { // CheckFunnelAccess checks whether Funnel access is allowed for the given node // and port. // It checks: -// 1. an invite was used to join the Funnel alpha +// 1. Funnel is enabled on the Tailnet // 2. HTTPS is enabled on the Tailnet // 3. the node has the "funnel" nodeAttr // 4. the port is allowed for Funnel @@ -190,7 +190,7 @@ func (sc *ServeConfig) IsFunnelOn() bool { // Funnel. func CheckFunnelAccess(port uint16, nodeAttrs []string) error { if slices.Contains(nodeAttrs, tailcfg.CapabilityWarnFunnelNoInvite) { - return errors.New("Funnel not available; an invite is required to join the alpha. See https://tailscale.com/s/no-funnel.") + return errors.New("Funnel not enabled; See https://tailscale.com/s/no-funnel.") } if slices.Contains(nodeAttrs, tailcfg.CapabilityWarnFunnelNoHTTPS) { return errors.New("Funnel not available; HTTPS must be enabled. See https://tailscale.com/s/https.") diff --git a/tailcfg/tailcfg.go b/tailcfg/tailcfg.go index 0e1b9d05b..6d206d682 100644 --- a/tailcfg/tailcfg.go +++ b/tailcfg/tailcfg.go @@ -1839,7 +1839,8 @@ const ( // Funnel warning capabilities used for reporting errors to the user. - // CapabilityWarnFunnelNoInvite indicates an invite has not been accepted for the Funnel alpha. + // CapabilityWarnFunnelNoInvite indicates whether Funnel is enabled for the tailnet. + // NOTE: In transition from Alpha to Beta, this capability is being reused as the enablement. CapabilityWarnFunnelNoInvite = "https://tailscale.com/cap/warn-funnel-no-invite" // CapabilityWarnFunnelNoHTTPS indicates HTTPS has not been enabled for the tailnet.