From 3553512a71531f4c373c8b53843e20058cb68657 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Wed, 24 Jun 2020 19:45:27 -0700 Subject: [PATCH] cmd/derper: fix embarassing bug introduced in earlier refactor The remove hook implementation was copy/pasted from the line above and I didn't change the body, resulting in packet forwarding routes never being removed. Fortunately we weren't using this path yet, but it led to stats being off, and (very) slow memory growth. --- cmd/derper/mesh.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/derper/mesh.go b/cmd/derper/mesh.go index 787ef189b..670d3f5e8 100644 --- a/cmd/derper/mesh.go +++ b/cmd/derper/mesh.go @@ -39,7 +39,7 @@ func startMeshWithHost(s *derp.Server, host string) error { } c.MeshKey = s.MeshKey() add := func(k key.Public) { s.AddPacketForwarder(k, c) } - remove := func(k key.Public) { s.AddPacketForwarder(k, c) } + remove := func(k key.Public) { s.RemovePacketForwarder(k, c) } go c.RunWatchConnectionLoop(s.PublicKey(), add, remove) return nil }