From 1f7a7a4ffe7c0b4540413874fd8dac2c782c91ee Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Mon, 10 Aug 2020 19:45:20 -0700 Subject: [PATCH] tailcfg: add missing Node.DERP check in Node.Equals Updates tailscale/corp#549 Signed-off-by: Brad Fitzpatrick --- tailcfg/tailcfg.go | 1 + tailcfg/tailcfg_test.go | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/tailcfg/tailcfg.go b/tailcfg/tailcfg.go index f441c8719..0d073a17d 100644 --- a/tailcfg/tailcfg.go +++ b/tailcfg/tailcfg.go @@ -628,6 +628,7 @@ func (n *Node) Equal(n2 *Node) bool { eqCIDRs(n.Addresses, n2.Addresses) && eqCIDRs(n.AllowedIPs, n2.AllowedIPs) && eqStrings(n.Endpoints, n2.Endpoints) && + n.DERP == n2.DERP && n.Hostinfo.Equal(&n2.Hostinfo) && n.Created.Equal(n2.Created) && eqTimePtr(n.LastSeen, n2.LastSeen) && diff --git a/tailcfg/tailcfg_test.go b/tailcfg/tailcfg_test.go index 435fd4620..b0d96c9f8 100644 --- a/tailcfg/tailcfg_test.go +++ b/tailcfg/tailcfg_test.go @@ -315,6 +315,11 @@ func TestNodeEqual(t *testing.T) { &Node{LastSeen: &now}, true, }, + { + &Node{DERP: "foo"}, + &Node{DERP: "bar"}, + false, + }, } for i, tt := range tests { got := tt.a.Equal(tt.b)