health: fix magicsockReceiveFuncWarnable health clearing

Fixes #13204 Change-Id: I7154cdabc9dc362dcc3221fd5a86e21f610bbff0 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
3 months ago · 13dee9db7b
parent 3d401c11fa
commit 13dee9db7b
1 changed files with 2 additions and 1 deletions
--- a/health/health.go
+++ b/health/health.go
@ -1064,7 +1064,7 @@ func (t *Tracker) updateBuiltinWarnablesLocked() {
 	_ = t.lastStreamedMapResponse
 	_ = t.lastMapRequestHeard

-	shouldClearMagicsockWarnings := false
+	shouldClearMagicsockWarnings := true
 	for i := range t.MagicSockReceiveFuncs {
 		f := &t.MagicSockReceiveFuncs[i]
 		if f.missing {
@ -1072,6 +1072,7 @@ func (t *Tracker) updateBuiltinWarnablesLocked() {
 				ArgMagicsockFunctionName: f.name,
 			})
 			shouldClearMagicsockWarnings = false
+			break
 		}
 	}
 	if shouldClearMagicsockWarnings {