From 0848b36dd254e4905dddbcb24731703a2f7ca317 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Sun, 19 Dec 2021 09:48:30 -0800 Subject: [PATCH] net/dns/resolver: add metrics to PTR lookup misses Updates tailscale/corp#3326 Change-Id: I58077d889a3b58ef0633267c92ffb265686ce152 Signed-off-by: Brad Fitzpatrick --- net/dns/resolver/tsdns.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/dns/resolver/tsdns.go b/net/dns/resolver/tsdns.go index 7c5258e0d..d9d6c736a 100644 --- a/net/dns/resolver/tsdns.go +++ b/net/dns/resolver/tsdns.go @@ -1087,11 +1087,13 @@ func rdnsNameToIPv6(name dnsname.FQDN) (ip netaddr.IP, ok bool) { // It is assumed that resp.Question is populated by respond before this is called. func (r *Resolver) respondReverse(query []byte, name dnsname.FQDN, resp *response) ([]byte, error) { if hasRDNSBonjourPrefix(name) { + metricDNSReverseMissBonjour.Add(1) return nil, errNotOurName } resp.Name, resp.Header.RCode = r.resolveLocalReverse(name) if resp.Header.RCode == dns.RCodeRefused { + metricDNSReverseMissOther.Add(1) return nil, errNotOurName } @@ -1235,4 +1237,7 @@ var ( metricDNSResolveLocalNoAll = clientmetric.NewCounter("dns_resolve_local_no_all") metricDNSResolveNotImplType = clientmetric.NewCounter("dns_resolve_local_not_impl_type") metricDNSResolveNoRecordType = clientmetric.NewCounter("dns_resolve_local_no_record_type") + + metricDNSReverseMissBonjour = clientmetric.NewCounter("dns_reverse_miss_bonjour") + metricDNSReverseMissOther = clientmetric.NewCounter("dns_reverse_miss_other") )