feature/relayserver: fix Shutdown() deadlock (#17898)

Updates #17894

Signed-off-by: Jordan Whited <jordan@tailscale.com>
pull/17893/head
Jordan Whited 3 weeks ago committed by GitHub
parent 124301fbb6
commit 0285e1d5fb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -246,10 +246,13 @@ func (e *extension) stopRelayServerLocked() {
// Shutdown implements [ipnlocal.Extension].
func (e *extension) Shutdown() error {
// [extension.mu] must not be held when closing the [eventbus.Client]. Close
// blocks until all [eventbus.SubscribeFunc]'s have returned, and the ones
// used in this package also acquire [extension.mu]. See #17894.
e.ec.Close()
e.mu.Lock()
defer e.mu.Unlock()
e.shutdown = true
e.ec.Close()
e.stopRelayServerLocked()
return nil
}

Loading…
Cancel
Save