From 8481795a860f200f0d4634f6071b0bf1bdccf753 Mon Sep 17 00:00:00 2001 From: Andrea Gottardo Date: Wed, 1 May 2024 10:02:30 -0700 Subject: [PATCH] mdm: improve logs when keys are undefined Let's make these log lines a bit less scary when MDM is not being used to enforce a value. Signed-off-by: Andrea Gottardo --- libtailscale/syspolicy_handler.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libtailscale/syspolicy_handler.go b/libtailscale/syspolicy_handler.go index 8b795f7..a311e1d 100644 --- a/libtailscale/syspolicy_handler.go +++ b/libtailscale/syspolicy_handler.go @@ -23,7 +23,7 @@ func (h syspolicyHandler) ReadString(key string) (string, error) { } retVal, err := h.a.appCtx.GetSyspolicyStringValue(key) if err != nil && !errors.Is(err, syspolicy.ErrNoSuchKey) { - log.Printf("syspolicy: failed to get string value via gomobile: %v", err) + log.Printf("syspolicy: %s (str) will not be set: %v", key, err) } return retVal, err } @@ -34,7 +34,7 @@ func (h syspolicyHandler) ReadBoolean(key string) (bool, error) { } retVal, err := h.a.appCtx.GetSyspolicyBooleanValue(key) if err != nil && !errors.Is(err, syspolicy.ErrNoSuchKey) { - log.Printf("syspolicy: failed to get bool value via gomobile: %v", err) + log.Printf("syspolicy: %s (bool) will not be set: %v", key, err) } return retVal, err } @@ -54,7 +54,7 @@ func (h syspolicyHandler) ReadStringArray(key string) ([]string, error) { } retVal, err := h.a.appCtx.GetSyspolicyStringArrayJSONValue(key) if err != nil && !errors.Is(err, syspolicy.ErrNoSuchKey) { - log.Printf("syspolicy: failed to get string array value via gomobile: %v", err) + log.Printf("syspolicy: %s (strArr) will not be set: %v", key, err) return nil, err } if retVal == "" {