From 5fc8a889c7c55cbb2375f97584c26607b41e7a4f Mon Sep 17 00:00:00 2001 From: kari-ts <135075563+kari-ts@users.noreply.github.com> Date: Thu, 19 Sep 2024 13:25:25 -0700 Subject: [PATCH] android: use onSuccess parameter in setWantRunning Previously we were never actually invoking this parameter We previously weren't setting vpnActive after closing IPNService Updates tailscale/corp#22284 Signed-off-by: kari-ts --- android/src/main/java/com/tailscale/ipn/App.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/src/main/java/com/tailscale/ipn/App.kt b/android/src/main/java/com/tailscale/ipn/App.kt index 95acce5..753200c 100644 --- a/android/src/main/java/com/tailscale/ipn/App.kt +++ b/android/src/main/java/com/tailscale/ipn/App.kt @@ -79,7 +79,7 @@ class App : UninitializedApp(), libtailscale.AppContext, ViewModelStoreOwner { override fun isPlayVersion(): Boolean = MaybeGoogle.isGoogle() - override fun shouldUseGoogleDNSFallback() : Boolean = BuildConfig.USE_GOOGLE_DNS_FALLBACK + override fun shouldUseGoogleDNSFallback(): Boolean = BuildConfig.USE_GOOGLE_DNS_FALLBACK override fun log(s: String, s1: String) { Log.d(s, s1) @@ -160,7 +160,7 @@ class App : UninitializedApp(), libtailscale.AppContext, ViewModelStoreOwner { fun setWantRunning(wantRunning: Boolean, onSuccess: (() -> Unit)? = null) { val callback: (Result) -> Unit = { result -> result.fold( - onSuccess = {}, + onSuccess = { onSuccess?.invoke() }, onFailure = { error -> Log.d("TAG", "Set want running: failed to update preferences: ${error.message}") })