From 57458542973d5ee7be62774045da68f8a145b53a Mon Sep 17 00:00:00 2001 From: kari-ts <135075563+kari-ts@users.noreply.github.com> Date: Thu, 4 Apr 2024 14:08:46 -0700 Subject: [PATCH] MainActivity: remove redundant Notifier start/stop (#293) We're starting Notifier in App so that states are available outside of MA lifecycle. Updates tailscale/corp#18202 Signed-off-by: kari-ts --- android/src/main/java/com/tailscale/ipn/MainActivity.kt | 5 ----- 1 file changed, 5 deletions(-) diff --git a/android/src/main/java/com/tailscale/ipn/MainActivity.kt b/android/src/main/java/com/tailscale/ipn/MainActivity.kt index 844c081..00e6abd 100644 --- a/android/src/main/java/com/tailscale/ipn/MainActivity.kt +++ b/android/src/main/java/com/tailscale/ipn/MainActivity.kt @@ -63,7 +63,6 @@ import kotlinx.coroutines.cancel import kotlinx.coroutines.launch class MainActivity : ComponentActivity() { - private var notifierScope: CoroutineScope? = null private lateinit var requestVpnPermission: ActivityResultLauncher companion object { @@ -254,9 +253,6 @@ class MainActivity : ComponentActivity() { override fun onStart() { super.onStart() - val scope = CoroutineScope(Dispatchers.IO) - notifierScope = scope - Notifier.start(lifecycleScope) // (jonathan) TODO: Requesting VPN permissions onStart is a bit aggressive. This should // be done when the user initiall starts the VPN @@ -264,7 +260,6 @@ class MainActivity : ComponentActivity() { } override fun onStop() { - Notifier.stop() super.onStop() val restrictionsManager = this.getSystemService(Context.RESTRICTIONS_SERVICE) as RestrictionsManager