Commit Graph

82 Commits (e493e72ffb29e0accdf11cf06b0f9641fdb4858f)

Author SHA1 Message Date
Varun Patil 35ea5025dd check-setup: recommend exif extension
JPEG previews are not correctly oriented when exif is not enabled
along with other issues. There's no easy way to discover this either.

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
1 year ago
MichaIng 7e725c5d94
Check for opcache.file_cache_only=1
which disables shared memory based OPcache with disk file cache used only, if enabled. In this case, "opcache.memory_consumption" and others do not apply, so show the correct performance recommendation to enable memory cache.

Signed-off-by: MichaIng <micha@dietpi.com>
1 year ago
MichaIng 03390ee791 Fix interned strings buffer check if 0 free bytes
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely.

This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched.

Signed-off-by: MichaIng <micha@dietpi.com>
1 year ago
Côme Chilliet 7ebbb6b2ca
Remove workarounds specific to 7.4
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
1 year ago
Simon L 73c5591f68
Merge pull request #35024 from nextcloud/deprecate/php74
Deprecate PHP7.4
2 years ago
Robin Appelman abaa3ef61b
Merge pull request #34485 from michaelkuhn/hasBigIntConversionPendingColumns-files_trash
Fix hasBigIntConversionPendingColumns missing files_trash
2 years ago
Christoph Wurst 75a1721d7d
Deprecate PHP7.4
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2 years ago
szaimen f9e9cd270d
Limit-number-of-concurrent-preview-generations
Signed-off-by: Bowen Ding <dbw9580@live.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
2 years ago
Michael Kuhn 9a205bdc84 Fix hasBigIntConversionPendingColumns missing files_trash
The two tables seem to have gone out of sync, causing the web interface
to miss `files_trash.auto_id` not being a bigint.

Signed-off-by: Michael Kuhn <github@ikkoku.de>
2 years ago
acsfer 4207b80141 Harden some PHP functions
To avoid things like https://github.com/nextcloud/server/issues/26034

Signed-off-by: Louis Chemineau <louis@chmn.me>
2 years ago
timm2k 0c407b58db
Update CheckSetupController.php
file_metadata.id needs to be bigint(20).

Signed-off-by: timm2k <timm2k@gmx.de>
2 years ago
szaimen cf9b1082ed add a setup check for 64 bit
Signed-off-by: szaimen <szaimen@e.mail.de>
2 years ago
szaimen f8bebb62ca do not display the buffer_size info if the size is already set to a certain threshold
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2 years ago
Valdnet 1bc6fb2c58
l10n: Change to a capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2 years ago
rakekniven d2830612d0
l10n: Improve grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2 years ago
MichaIng 31606c9861 Add OPcache recommendations to Transifex
Fixes: https://github.com/nextcloud/server/issues/30941

Signed-off-by: MichaIng <micha@dietpi.com>
2 years ago
Simon L 3a0b934f84
Merge pull request #31430 from nextcloud/enh/31429/improve-overwrite-cli-url-check
Validate `overwrite.cli.url` to be a url in setup check
2 years ago
szaimen 4191a178dd improve overwrite cli url setup check
Signed-off-by: szaimen <szaimen@e.mail.de>
2 years ago
John Molakvoæ 23e8ae15aa
Merge pull request #31470 from nextcloud/enh/13099/allow-disable-imagick-warning 2 years ago
szaimen 7dca146b58 allow to disable the imagick warning
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2 years ago
Julien Veyssier d5574cf189
allow adding protocol to domains in 'connectivity_check_domains' config
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2 years ago
MichaIng 3980322621
Merge pull request #31267 from nextcloud/enh/docs-link-for-opcache-recommends
Add Nextcloud docs link to OPcache recommends
2 years ago
MichaIng 5ac91f1cb8 Add Nextcloud docs link to OPcache recommends
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.

Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.

Signed-off-by: MichaIng <micha@dietpi.com>
2 years ago
Mickey Knox f63eb4261f Fix permittedPath comparison
Signed-off-by: Mickey Knox <mickey@netfreaks.org>
2 years ago
Arthur Schiwon b28aa52b28
Setup warning for invalid LDAP user or group UUIDs.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2 years ago
szaimen 84cf39f582 show if the mail server settings are not set or verified
Signed-off-by: szaimen <szaimen@e.mail.de>
2 years ago
MichaIng 79cdb565dc Avoid zero division in setup checks
Fixes: https://github.com/nextcloud/server/issues/30532

Signed-off-by: MichaIng <micha@dietpi.com>
2 years ago
MichaIng 82c1beaacb Enhance and complement OPcache setup checks
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.

With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.

The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.

A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.

OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.

Signed-off-by: MichaIng <micha@dietpi.com>
2 years ago
Joas Schilling 19d070850b
Make sure trusted_proxies is an array
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
Vitor Mattos e55ceb2bb1
Show warning on admin settings page
Signed-off-by: Vitor Mattos <vitor@php.rio>
3 years ago
Christoph Wurst 4b8f8c5203
Deprecate PHP7.3 for Nextcloud 23
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Carl Schwan 6958d8005a
Add admin privilege delegation for admin settings
This makes it possible for selected groups to access some settings
pages.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
3 years ago
Stefan eb46011680 Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
3 years ago
Stefan 8758b36ebb Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
3 years ago
Carl Schwan 07ccccecad
Only recommand for php-sodium on >= PHP 7.4
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.

So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
3 years ago
Carl Schwan 8e51a5feda
Check that php was compiled with argon2 support or that the php-sodium
extensions is installed

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
3 years ago
John Molakvoæ (skjnldsv) 215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
3 years ago
Valdnet 9c6b01abeb
l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
3 years ago
Roeland Jago Douma bd2e6309b5
Merge pull request #25605 from nextcloud/trusted-proxy-warning-localhost
dont show trusted proxy warning when the proxy and remote are both localhost
3 years ago
Roeland Jago Douma 2afa1c5739
Merge pull request #25862 from nextcloud/techdept/psalm/some_loggers
Move away some ILoggers
3 years ago
Roeland Jago Douma 38f761f25f Move away some ILoggers
Makes psalm happier

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Roeland Jago Douma 3d0dff0d2b Fix lying docblocks
* typed the return
* removed unneeded temp variable

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Roeland Jago Douma 7d8e9baa77
Revert "use the configured forwarded headers for the setup check" 3 years ago
Robin Appelman 01118a2218
use the configured forwarded headers for the setup check
instead of always checking against the same header

Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
Robin Appelman cc0cc68c8d
dont show trusted proxy warning when the proxy and remote are both localhost
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
Christoph Wurst c1d4f8161b
Migrate internal classes to the OCP db col types
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Roeland Jago Douma 6c8f2dc7bc
Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-db
Add setup check to verify that the used DB version is still supported…
3 years ago
Morris Jobke 24d436cb60
Remove unneeded casts that were found by Psalm
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Morris Jobke bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Christoph Wurst 8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago