Commit Graph

6368 Commits (stable24)

Author SHA1 Message Date
Joas Schilling 1eabc0da09 fix: Extend SVG reference check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2 weeks ago
Christopher Ng ebfac5f273 test: Update tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2 months ago
Christoph Wurst ef024d40e0 fix(config): Make sure user keys are strings
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2 months ago
Côme Chilliet da391a550f Fix tests, add test for the new feature
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
3 months ago
Joas Schilling 2fd3a372f7
Reverse X-Forwarded-For list to read the correct proxy remote address
Signed-off-by: Joas Schilling <coding@schilljs.com>
7 months ago
Joas Schilling e65b577b4f
Merge pull request #39254 from nextcloud/backport/38046/stable24
[stable24] fix(dav): Abort requests with 429 instead of waiting
11 months ago
Joas Schilling 7b6a2a041c
fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
11 months ago
Joas Schilling 66cf085767
fix(l10n): Fix plural issue with different locale and language
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>
11 months ago
Joas Schilling fc3d3bedcf
Merge pull request #38277 from nextcloud/backport/38274/stable24
[stable24] fix(middleware): Also abort the request when reaching max delay in af…
1 year ago
Joas Schilling 510fc26600
fix(middleware): Also abort the request when reaching max delay in afterController
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Joas Schilling 19b7545599
fix(tests): Adjust unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Joas Schilling 77a956020c feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Daniel Kesselberg a561c32f71 chore: use local variable for remote address
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1 year ago
Arthur Schiwon 7e4853089d
Merge pull request #36750 from nextcloud/backport/36689/stable24
[stable24] Change X-Robots-Tag header from "none" to "noindex, nofollow"
1 year ago
Arthur Schiwon a3a05f4a06
Merge pull request #36900 from nextcloud/backport/stable24/36837
[stable24] fix(SystemTagManager): Truncate overlong tag names
1 year ago
Arthur Schiwon 0a9f73caa8
Merge pull request #36743 from nextcloud/backport/35419/stable24
[stable24] Fix login loop if login CSRF fails and user is not logged in
1 year ago
Julien Veyssier 5b08f8481c
manual backport of #35057
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
1 year ago
Simon L ea6b4c69c9
Merge pull request #37004 from nextcloud/backport/36803/stable24
[stable24] [db]: Remove not supported column comments for SQLite
1 year ago
Ferdinand Thiessen 2f0c60dccc tests(db): Add test case to ensure column comments work
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
1 year ago
Marcel Klehr 60395a898e fix(SystemTagManager): Truncate overlong tag names
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
1 year ago
Christoph Wurst 2b868af78b fix(client-login-flow): Handle missing stateToken gracefully
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
1 year ago
Julius Härtl a04ed00f63 fix: Avoid resetting scss cacher when no variables are found
Signed-off-by: Julius Härtl <jus@bitgrid.net>
1 year ago
MichaIng 30c0937205 Change X-Robots-Tag header from "none" to "noindex, nofollow"
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240

Signed-off-by: MichaIng <micha@dietpi.com>
1 year ago
Christoph Wurst 793dbe2d22
Fix login loop if login CSRF fails and user is not logged in
If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
1 year ago
Joas Schilling f89eacbf86
fix(CI): Adjust expected result
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Joas Schilling 6761b94f4f
Remove failing test that works with mocks only anyway
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Joas Schilling 8b81770156
Skip failing avatar test with PHP 8.0
The font is placed one pixel off

Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Artur Neumann bcfd571d83 unit tests for Manager::invalidateTokensOfUser
Signed-off-by: Artur Neumann <artur@jankaritech.com>
1 year ago
Vincent Petry 28b8d6b94f
Merge pull request #35799 from nextcloud/backport/35780/stable24
[stable24] Fix missing cast of double controller parameters
1 year ago
Christoph Wurst 7fceb57843 fix(app framework): Fix missing cast of double controller parameters
``settype`` allows 'double' as alias of 'float'.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
1 year ago
Vincent Petry 07361adb48
Merge pull request #35657 from nextcloud/backport/35649/stable24
[stable24] Update the unencrypted file size when closing streams
1 year ago
Artur Neumann 8cf9878fd2 check if params given to API are really an array
Signed-off-by: Artur Neumann <artur@jankaritech.com>
1 year ago
Julius Härtl d843ba9822 Also update the unencrypted size of files when creating them with empty content
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2 years ago
Côme Chilliet e24df2255d
Merge pull request #35141 from nextcloud/backport/34160/stable24
[stable24] Detect weird local ips
2 years ago
Côme Chilliet e0d588b390
Fix tests for nested v4 in v6
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
Côme Chilliet e5b4a097e8
Harden tests for local IP detection in URLs
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
Joas Schilling 9aa3496913 Run integration tests on 3rdparty bump
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2 years ago
Christoph Wurst b059ea1175 Fix PublicKeyTokenProviderTest import and mock
* IDBConnection import missing
* Atomic doesn't need a mock

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2 years ago
Vincent Petry 1f730ec9e2
Merge pull request #34659 from nextcloud/backport/34632/stable24
[stable24] Add rate limiting on lost password emails
2 years ago
Vincent Petry 8b4fe66c14
Merge pull request #34855 from nextcloud/backport/34799/stable24
[stable24] Emit typed event when preview is requested
2 years ago
Vincent Petry 2efb811301
Merge pull request #34947 from nextcloud/backport/34804/stable24
[stable24] Skip general login with email for non-valid addresses and LDAP
2 years ago
Côme Chilliet 7dc7d0cb11
Fix LostController test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
Christoph Wurst 6d2677b2bb
Run session token renewals in a database transaction
The session token renewal does
1) Read the old token
2) Write a new token
3) Delete the old token

If two processes succeed to read the old token there can be two new tokens because
the queries were not run in a transaction. This is particularly problematic on
clustered DBs where 1) would go to a read node and 2) and 3) go to a write node.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2 years ago
Julius Härtl 91a4444c2b
Skip general login with email for non-valid addresses and LDAP
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2 years ago
Julius Härtl 6dc2b162c5
Emit typed event when preview is requested
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2 years ago
John Molakvoæ 04ec0d7f97
Merge pull request #34440 from nextcloud/backport/32635/stable24 2 years ago
Vincent Petry 1524b5fd25
Merge pull request #34797 from nextcloud/backport/33540/stable24
[stable24] fix updating cached mounts that didn't have their mount provider set previously
2 years ago
John Molakvoæ 220d71d997
Merge pull request #34410 from nextcloud/backport/33566/stable24 2 years ago
Andy Xheli 029a9ee39f Update ContactsStoreTest.php
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
2 years ago
Julius Härtl bc3572ebc3 Check share attributes on preview endpoints
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2 years ago