Commit Graph

6222 Commits (stable23)

Author SHA1 Message Date
Christoph Wurst 876522204e fix(config): Make sure user keys are strings
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2 months ago
Côme Chilliet 3e80a03e92 Fix tests, add test for the new feature
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
3 months ago
Joas Schilling d4f6fff9ad
Reverse X-Forwarded-For list to read the correct proxy remote address
Signed-off-by: Joas Schilling <coding@schilljs.com>
7 months ago
Joas Schilling 8c013734f7
fix(tests): Adjust unit tests in backport
Signed-off-by: Joas Schilling <coding@schilljs.com>
11 months ago
Joas Schilling 9d6a7399a8
fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
11 months ago
Joas Schilling a09a4b60a9
Merge pull request #38278 from nextcloud/backport/38274/stable23
[stable23] fix(middleware): Also abort the request when reaching max delay in af…
1 year ago
Joas Schilling 060b85c311
fix(middleware): Also abort the request when reaching max delay in afterController
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Joas Schilling 8edb6b3e65
fix(tests): Adjust unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Joas Schilling fd892cddf1 feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Daniel Kesselberg 1c333cd1ea chore: use local variable for remote address
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1 year ago
Julien Veyssier b384a969f5
manual backport of #35057
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
1 year ago
Christoph Wurst b9baa624bc
Fix login loop if login CSRF fails and user is not logged in
If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
1 year ago
Joas Schilling 45af8b59a1
fix(CI): Adjust expected result
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Joas Schilling 7676103f4d
Remove failing test that works with mocks only anyway
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Joas Schilling 0de128d0b6
Skip failing avatar test with PHP 8.0
The font is placed one pixel off

Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Côme Chilliet 3a61963980
Avoid select with no FROM clause for Oracle in tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
1 year ago
Côme Chilliet 131a397472
Add octetLength and charLength to function builder, and tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
1 year ago
Côme Chilliet 96d3d09444
Fix tests for nested v4 in v6
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
Côme Chilliet 1c58ba500b
Harden tests for local IP detection in URLs
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
Vincent Petry ca6eaebe85
Merge pull request #34660 from nextcloud/backport/34632/stable23
[stable23] Add rate limiting on lost password emails
2 years ago
Côme Chilliet d52925cf2c
Fix LostController test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
Julius Härtl 0d3a6b5213
Skip general login with email for non-valid addresses and LDAP
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2 years ago
szaimen 53787e2d3b fix external storages access
Signed-off-by: szaimen <szaimen@e.mail.de>
2 years ago
blizzz 2cd11e23cd
Merge pull request #33792 from nextcloud/backport/stable23-wait-for-the-new-user-form-to-be-visible-in-acceptance-tests
[stable23] Wait for the new user form to be visible in acceptance tests
2 years ago
Carl Schwan 4d4a6727fc Filter out old files when trying to get recent files
Only do so when asking for less than 100 files and having an offset
equal to 0.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2 years ago
Daniel Calviño Sánchez ee68e4cf44 Wait for the new user form to be visible
Before it was checked if the new user form was visible, but it was not
waited for it. It seems that it can happen that the new user form is in
the DOM, and therefore found, but not visible yet when the tests run,
which caused them to (randomly) fail. Due to that now it is explicitly
waited until it is visible, rather than assuming that it is visible as
soon as it appears in the DOM.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2 years ago
Thomas Citharel 54b0b53295
Fix logging data context to file
It was only logged when an exception was provided or when using
logData (which is not being much used).

We make sure the interpolated parameters are not logged.

Only tested with file write logger, but shouldn't work differently.

Crash reporters always had the context.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2 years ago
blizzz d7c442deaa
Merge pull request #33443 from nextcloud/backport/33407/stable23
[stable23] Handle one time and large passwords
2 years ago
Carl Schwan bc29ff5567
Handle one time and large passwords
For passwords bigger than 250 characters, use a bigger key since the
performance impact is minor (around one second to encrypt the password).

For passwords bigger than 470 characters, give up earlier and throw
exeception recommanding admin to either enable the previously enabled
configuration or use smaller passwords.

This adds an option to disable storing passwords in the database. This
might be desirable when using single use token as passwords or very
large passwords.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2 years ago
Côme Chilliet 91a244e77e Use Symfony IpUtils to check for local IP ranges
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
Thomas Citharel 1c0342af58 Fix reading blob data as resource
PostgreSQL returns data as resource when using IQueryBuilder::PARAM_LOB
(which is used for QBMapper).

Previously we just converted this resource using settype, which produced
things like "Resource id #14" instead of the actual resource data.

Now we read the stream correctly if the returned data is a resource

See context at #22472

Fixes #22439

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2 years ago
Carl Schwan 3750160d9f Allow to disable password policy enforcement for selected groups
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2 years ago
blizzz 14af5f3c26
Merge pull request #33004 from nextcloud/backport/32719/stable23
[stable23] Fix email shares not being shown to other users
2 years ago
Louis Chemineau 768b41ee45 Rename setting name to reduce its length
Signed-off-by: Louis Chemineau <louis@chmn.me>
2 years ago
Richard Steinmetz 6397113284
Fix email shares not being shown to other users
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2 years ago
Louis 6644b17527
Merge pull request #32322 from nextcloud/backport/stable22/share_search_tweaks
[stable23] Add share search tweaks
2 years ago
blizzz e7e782b831
Merge pull request #32871 from nextcloud/backport/32813/stable23
[stable23] Run php tests when 3rdparty changed
2 years ago
Arthur Schiwon 813a14a226
make placeholder a const for reuse
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2 years ago
Arthur Schiwon 263eca767d
fix overwriting original vars when logging
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2 years ago
Arthur Schiwon 33b442e9a5
add serializer test
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2 years ago
Daniel Kesselberg 70a127a3d1 Run php tests when 3rdparty changed
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2 years ago
Vincent Petry ce7b7226da
Merge pull request #32658 from nextcloud/backport/32655/stable23
[stable23] Handle non existing settings again
2 years ago
Christopher Ng 4e04f4e883 Test all scopes
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2 years ago
Christopher Ng e6e5e08d78 Fix get avatar authorization
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2 years ago
Louis Chemineau e297e1ce18 Add settings to ignore second display name in search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2 years ago
Vincent Petry c2c65c26fd Add unit tests for encryption's isSystemWideMountPoint
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2 years ago
Joas Schilling c49b255b01
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2 years ago
Joas Schilling 33c21e1b74
Merge pull request #32422 from nextcloud/backport/32375/stable23
[stable23] Show user account on grant loginflow step
2 years ago
Joas Schilling e432abdb1b Extend tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2 years ago
Joas Schilling 82ada01ad6 Fix user agent trimming on installation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2 years ago