Commit Graph

113 Commits (stable22)

Author SHA1 Message Date
Joas Schilling ff46977237
Fix phpunit version used in s3 external testing
Signed-off-by: Joas Schilling <coding@schilljs.com>
1 year ago
Carl Schwan efdbbbd716
Update node js ci job
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2 years ago
John Molakvoæ 56153ed19f Prevent merging on EOL branches
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2 years ago
Robin Appelman c651fc2078 Add test for samba kerberos sso in ci
Signed-off-by: Robin Appelman <robin@icewind.nl>
2 years ago
Joas Schilling a8847c022b Create block-merge-freeze.yml
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2 years ago
MichaIng 7375a1b747 [stable22] Remove iconv from dependencies and tests
which is not used anymore since: https://github.com/nextcloud/server/pull/29470

Signed-off-by: MichaIng <micha@dietpi.com>
2 years ago
John Molakvoæ 668895ad25
Jsunit requires npm6
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2 years ago
John Molakvoæ 91ad520de9
Add branch-suffix to update-psalm-baseline PR creation
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
3 years ago
John Molakvoæ 1f3a9c6337
[stable22] Update update-psalm-baseline workflow
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
3 years ago
Robin Appelman a3d365b33b ci
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
Robin Appelman a4a4097068 s3 external storage listing rework
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
Morris Jobke 050ba4b8d2 Change output format of Psalm to Github
This automatically inlines the errors into the diff view.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Christoph Wurst eda2be4972 Pin Psalm version for security analysis
The action will otherwise pull dev-master and this can break easily as
we just experience.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
John Molakvoæ 837c08892b
Add files via upload 3 years ago
Morris Jobke deaf0f3aa2
Change reviewers of Psalm baseline update
Change reviewers from Roeland and Me to Julius and Louis

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
John Molakvoæ 8c8777a841
Fix name 3 years ago
John Molakvoæ 38a19c263b
Add fixup.yml 3 years ago
John Molakvoæ 162229dbff
Fix psalm action 3 years ago
John Molakvoæ fb583d5665
Fix psalm action 3 years ago
John Molakvoæ f2e731e017
Add dependabot reviewer team and remove saturday for stable branches
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
3 years ago
John Molakvoæ 018e18bf8a
Fix dependabot config 3 years ago
John Molakvoæ (skjnldsv) c3f9f09fb0
Add dependabot config with proper ignore for stable branches
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
3 years ago
Christoph Wurst ab3424ad44
Add ext-zip as platform dependency
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Joas Schilling 6a43948a6e
FIx Oracle by testing on Ubuntu 20.04 until oci8.so is available for 21.04
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
acsfer 2e41939ece
Typo 3 years ago
acsfer 9f56646694
Redirect users to forum for questions
Be more specific so more users will go directly to the forum instead using Github for non-bug reports.
3 years ago
John Molakvoæ (skjnldsv) fb183b457c
Add eslint testing
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
3 years ago
tobiasKaminsky bfb535b2b2
Add funding info
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
3 years ago
Roeland Jago Douma da652ded26 Move fixup check to action
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Roeland Jago Douma cc18213c98 Have psalm analysis directly on github
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Roeland Jago Douma 08cae2ec44
Revert "Pin Psalm version to an older one" 3 years ago
Lukas Reschke f1d2dcdaa5 Pin Psalm version to an older one
Ref https://github.com/vimeo/psalm/issues/5144

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
3 years ago
Roeland Jago Douma c96bb21ab9
Merge pull request #24903 from nextcloud/enh/psalm-ocp
Add dedicated baseline for OCP
3 years ago
Roeland Jago Douma fe65f8facf
Add dedicated baseline for OCP
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Julius Härtl c42385ef0f
Cleanup bundle files before checking the rebuild
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 years ago
Julius Härtl c7a320d880 jsunit: Run jsunit with chromium/puppeteer on github actions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 years ago
Morris Jobke 6811274cfd
Merge pull request #24246 from LukasReschke/add-taint-flow-analysis
Add Psalm Security Analysis
4 years ago
Lukas Reschke 47ac8e0028
Add Psalm Taint Flow Analysis
This adds the Psalm Security Analysis, as described at
https://psalm.dev/docs/security_analysis/

It also adds a plugin for adding input into AppFramework.

The results can be viewed in the GitHub Security tab at
https://github.com/nextcloud/server/security/code-scanning

**Q&A:**

Q: Why do you not use the shipped Psalm version?
A: I do a lot of changes to the Psalm Taint behaviour. Using released
versions is not gonna get us the results we want.

Q: How do I improve false positives?
A: https://psalm.dev/docs/security_analysis/avoiding_false_positives/

Q: How do I add custom sources?
A: https://psalm.dev/docs/security_analysis/custom_taint_sources/

Q: We should run this on apps!
A: Yes.

Q: What will change in Psalm?
A: Quite some of the PHP core functions are not yet marked to propagate
the taint. This leads to results where the taint flow is lost. That's
something that I am currently working on.

Q: Why is the plugin MIT licensed?
A: Because its the first of its kind (based on GitHub Code Search) and
I want other people to copy it if they want to. Security is for all :)

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
4 years ago
Roeland Jago Douma 12f322d804
Also lint php8
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
4 years ago
Joas Schilling a524e83be0
Fix naming of jobs and steps
Signed-off-by: Joas Schilling <coding@schilljs.com>
4 years ago
Julius Härtl 2050517d44
Add github action for oci8
Signed-off-by: Julius Härtl <jus@bitgrid.net>
4 years ago
John Molakvoæ 1e7a82d99e
Fix php lint action 4 years ago
Morris Jobke bb05f0e4eb
Do not commit updated composer dependencies in psalm baseline update
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years ago
Morris Jobke f18d9cd310
Update daily "update psalm baseline" job to composer psalm
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years ago
Morris Jobke 106c8d719c
Do not fail on changes to baseline.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years ago
Christoph Wurst 081e9ac47f
Use own psalm instead of a global one
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
4 years ago
John Molakvoæ 28df9239bb
Delete dependabot.yml 4 years ago
John Molakvoæ (skjnldsv) d939f2fa5a
Split target-branch between stablexx branches until it supports Arrays
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
4 years ago
John Molakvoæ (skjnldsv) 91e463ff00
Move to automated dependabot merging
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
4 years ago
Morris Jobke 886466d510
Run psalm-baseline.xml update once a day
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
4 years ago