From 35ea5025dd0bd69f4613c7c324687fa9af5aba9e Mon Sep 17 00:00:00 2001 From: Varun Patil Date: Fri, 24 Mar 2023 18:29:18 -0700 Subject: [PATCH] check-setup: recommend exif extension JPEG previews are not correctly oriented when exif is not enabled along with other issues. There's no easy way to discover this either. Signed-off-by: Varun Patil --- apps/settings/lib/Controller/CheckSetupController.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/apps/settings/lib/Controller/CheckSetupController.php b/apps/settings/lib/Controller/CheckSetupController.php index a6f4d7a0d41..82a7e118d06 100644 --- a/apps/settings/lib/Controller/CheckSetupController.php +++ b/apps/settings/lib/Controller/CheckSetupController.php @@ -724,6 +724,12 @@ Raw output $recommendedPHPModules[] = 'sysvsem'; } + if (!extension_loaded('exif')) { + // used to extract metadata from images + // required for correct orientation of preview images + $recommendedPHPModules[] = 'exif'; + } + if (!defined('PASSWORD_ARGON2I')) { // Installing php-sodium on >=php7.4 will provide PASSWORD_ARGON2I // on previous version argon2 wasn't part of the "standard" extension