mirror of https://github.com/nextcloud/server.git
configurable amount of autocomplete results in comments
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>pull/6982/head
parent
bd951e926f
commit
ca72c0150b
@ -0,0 +1,45 @@
|
||||
<?php
|
||||
/**
|
||||
* @copyright Copyright (c) 2017 Arthur Schiwon <blizzz@arthur-schiwon.de>
|
||||
*
|
||||
* @author Arthur Schiwon <blizzz@arthur-schiwon.de>
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
namespace OCA\Comments;
|
||||
|
||||
|
||||
use OCP\IServerContainer;
|
||||
|
||||
class JSSettingsHelper {
|
||||
/** @var IServerContainer */
|
||||
private $c;
|
||||
|
||||
public function __construct(IServerContainer $c) {
|
||||
$this->c = $c;
|
||||
}
|
||||
|
||||
public function extend(array $settings) {
|
||||
$appConfig = json_decode($settings['array']['oc_appconfig'], true);
|
||||
|
||||
$value = (int)$this->c->getConfig()->getAppValue('comments', 'maxAutoCompleteResults', 10);
|
||||
$appConfig['comments']['maxAutoCompleteResults'] = $value;
|
||||
|
||||
$settings['array']['oc_appconfig'] = json_encode($appConfig);
|
||||
}
|
||||
}
|
@ -0,0 +1,73 @@
|
||||
<?php
|
||||
/**
|
||||
* @copyright Copyright (c) 2017 Arthur Schiwon <blizzz@arthur-schiwon.de>
|
||||
*
|
||||
* @author Arthur Schiwon <blizzz@arthur-schiwon.de>
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
namespace OCA\Comments\Tests\Unit;
|
||||
|
||||
use OCA\Comments\JSSettingsHelper;
|
||||
use OCP\IConfig;
|
||||
use OCP\IServerContainer;
|
||||
use Test\TestCase;
|
||||
|
||||
class JSSettingsHelperTest extends TestCase {
|
||||
/** @var IServerContainer|\PHPUnit_Framework_MockObject_MockObject */
|
||||
protected $c;
|
||||
/** @var JSSettingsHelper */
|
||||
protected $helper;
|
||||
|
||||
public function setUp() {
|
||||
parent::setUp();
|
||||
|
||||
$this->c = $this->createMock(IServerContainer::class);
|
||||
|
||||
$this->helper = new JSSettingsHelper($this->c);
|
||||
}
|
||||
|
||||
public function testExtend() {
|
||||
$config = $this->createMock(IConfig::class);
|
||||
$config->expects($this->once())
|
||||
->method('getAppValue')
|
||||
->with('comments', 'maxAutoCompleteResults')
|
||||
->willReturn(13);
|
||||
|
||||
$this->c->expects($this->once())
|
||||
->method('getConfig')
|
||||
->willReturn($config);
|
||||
|
||||
$config = [
|
||||
'oc_appconfig' => json_encode([
|
||||
'anotherapp' => [
|
||||
'foo' => 'bar',
|
||||
'foobar' => true
|
||||
]
|
||||
])
|
||||
];
|
||||
|
||||
$this->helper->extend(['array' => &$config]);
|
||||
|
||||
$appConfig = json_decode($config['oc_appconfig'], true);
|
||||
$this->assertTrue(isset($appConfig['comments']));
|
||||
$this->assertTrue(isset($appConfig['anotherapp']));
|
||||
$this->assertSame(2, count($appConfig['anotherapp']));
|
||||
$this->assertSame(13, $appConfig['comments']['maxAutoCompleteResults']);
|
||||
}
|
||||
}
|
Loading…
Reference in New Issue