fix(files): Remove confusing table header labels

For screen readers the table header was very verbose and confusing,
as the SR reads out e.g. "sort list by name button FILENAME" for every row / file.
Instead reduce it to "name button FILENAME" and add information about sorting to caption, as recommended by WCAG [1]

[1]: https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
pull/41951/head
Ferdinand Thiessen 6 months ago
parent 0fc8c15cd2
commit bb12b8e042
No known key found for this signature in database
GPG Key ID: 45FAE7268762B400

@ -25,7 +25,6 @@
'files-list__column-sort-button--active': sortingMode === mode,
'files-list__column-sort-button--size': sortingMode === 'size',
}]"
:aria-label="sortAriaLabel"
:alignment="mode === 'size' ? 'end' : 'start-reverse'"
type="tertiary"
@click="toggleSortBy(mode)">
@ -71,13 +70,6 @@ export default defineComponent({
},
},
computed: {
sortAriaLabel() {
return this.t('files', 'Sort list by {column}', {
column: this.name,
})
},
},
methods: {
t: translate,
},

@ -182,8 +182,9 @@ export default defineComponent({
caption() {
const defaultCaption = t('files', 'List of files and folders.')
const viewCaption = this.currentView.caption || defaultCaption
const sortableCaption = t('files', 'Column headers with buttons are sortable.')
const virtualListNote = t('files', 'This list is not fully rendered for performance reasons. The files will be rendered as you navigate through the list.')
return viewCaption + '\n' + virtualListNote
return `${viewCaption}\n${sortableCaption}\n${virtualListNote}`
},
},

Loading…
Cancel
Save