mirror of https://github.com/nextcloud/server.git
Merge pull request #42918 from nextcloud/backport/setupchecks-2/stable28
[stable28] Setup check migrations to new APIpull/42982/head
Arthur Schiwon
4 months ago
committed by
GitHub
commit
b692fbf061
@ -0,0 +1,76 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
/**
|
||||
* @copyright Copyright (c) 2023 Côme Chilliet <come.chilliet@nextcloud.com>
|
||||
*
|
||||
* @author Côme Chilliet <come.chilliet@nextcloud.com>
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
namespace OCA\Settings\SetupChecks;
|
||||
|
||||
use OC\IntegrityCheck\Checker;
|
||||
use OCP\IL10N;
|
||||
use OCP\IURLGenerator;
|
||||
use OCP\SetupCheck\ISetupCheck;
|
||||
use OCP\SetupCheck\SetupResult;
|
||||
|
||||
class CodeIntegrity implements ISetupCheck {
|
||||
public function __construct(
|
||||
private IL10N $l10n,
|
||||
private IURLGenerator $urlGenerator,
|
||||
private Checker $checker,
|
||||
) {
|
||||
}
|
||||
|
||||
public function getName(): string {
|
||||
return $this->l10n->t('Code integrity');
|
||||
}
|
||||
|
||||
public function getCategory(): string {
|
||||
return 'security';
|
||||
}
|
||||
|
||||
public function run(): SetupResult {
|
||||
if (!$this->checker->isCodeCheckEnforced()) {
|
||||
return SetupResult::info($this->l10n->t('Integrity checker has been disabled. Integrity cannot be verified.'));
|
||||
} elseif ($this->checker->hasPassedCheck()) {
|
||||
return SetupResult::success($this->l10n->t('No altered files'));
|
||||
} else {
|
||||
return SetupResult::error(
|
||||
$this->l10n->t('Some files have not passed the integrity check. {link1} {link2}'),
|
||||
$this->urlGenerator->linkToDocs('admin-code-integrity'),
|
||||
[
|
||||
'link1' => [
|
||||
'type' => 'highlight',
|
||||
'id' => 'getFailedIntegrityCheckFiles',
|
||||
'name' => 'List of invalid files…',
|
||||
'link' => $this->urlGenerator->linkToRoute('settings.CheckSetup.getFailedIntegrityCheckFiles'),
|
||||
],
|
||||
'link2' => [
|
||||
'type' => 'highlight',
|
||||
'id' => 'rescanFailedIntegrityCheck',
|
||||
'name' => 'Rescan…',
|
||||
'link' => $this->urlGenerator->linkToRoute('settings.CheckSetup.rescanFailedIntegrityCheck'),
|
||||
],
|
||||
],
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
@ -0,0 +1,62 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
/**
|
||||
* @copyright Copyright (c) 2023 Côme Chilliet <come.chilliet@nextcloud.com>
|
||||
*
|
||||
* @author Côme Chilliet <come.chilliet@nextcloud.com>
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
namespace OCA\Settings\SetupChecks;
|
||||
|
||||
use OCP\IConfig;
|
||||
use OCP\IL10N;
|
||||
use OCP\SetupCheck\ISetupCheck;
|
||||
use OCP\SetupCheck\SetupResult;
|
||||
|
||||
class CronErrors implements ISetupCheck {
|
||||
public function __construct(
|
||||
private IL10N $l10n,
|
||||
private IConfig $config,
|
||||
) {
|
||||
}
|
||||
|
||||
public function getCategory(): string {
|
||||
return 'system';
|
||||
}
|
||||
|
||||
public function getName(): string {
|
||||
return $this->l10n->t('Cron errors');
|
||||
}
|
||||
|
||||
public function run(): SetupResult {
|
||||
$errors = json_decode($this->config->getAppValue('core', 'cronErrors', ''), true);
|
||||
if (is_array($errors) && count($errors) > 0) {
|
||||
return SetupResult::error(
|
||||
$this->l10n->t(
|
||||
"It was not possible to execute the cron job via CLI. The following technical errors have appeared:\n%s",
|
||||
implode("\n", array_map(fn (array $error) => '- '.$error['error'].' '.$error['hint'], $errors))
|
||||
)
|
||||
);
|
||||
} else {
|
||||
return SetupResult::success($this->l10n->t('The last cron job ran without errors.'));
|
||||
}
|
||||
}
|
||||
}
|
||||
@ -0,0 +1,81 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
/**
|
||||
* @copyright Copyright (c) 2023 Côme Chilliet <come.chilliet@nextcloud.com>
|
||||
*
|
||||
* @author Côme Chilliet <come.chilliet@nextcloud.com>
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
namespace OCA\Settings\SetupChecks;
|
||||
|
||||
use OCP\IConfig;
|
||||
use OCP\IDateTimeFormatter;
|
||||
use OCP\IL10N;
|
||||
use OCP\IURLGenerator;
|
||||
use OCP\SetupCheck\ISetupCheck;
|
||||
use OCP\SetupCheck\SetupResult;
|
||||
|
||||
class CronInfo implements ISetupCheck {
|
||||
public function __construct(
|
||||
private IL10N $l10n,
|
||||
private IConfig $config,
|
||||
private IURLGenerator $urlGenerator,
|
||||
private IDateTimeFormatter $dateTimeFormatter,
|
||||
) {
|
||||
}
|
||||
|
||||
public function getCategory(): string {
|
||||
return 'system';
|
||||
}
|
||||
|
||||
public function getName(): string {
|
||||
return $this->l10n->t('Cron last run');
|
||||
}
|
||||
|
||||
public function run(): SetupResult {
|
||||
$lastCronRun = (int)$this->config->getAppValue('core', 'lastcron', '0');
|
||||
$relativeTime = $this->dateTimeFormatter->formatTimeSpan($lastCronRun);
|
||||
|
||||
if ((time() - $lastCronRun) > 3600) {
|
||||
return SetupResult::error(
|
||||
$this->l10n->t(
|
||||
'Last background job execution ran %s. Something seems wrong. {link}.',
|
||||
[$relativeTime]
|
||||
),
|
||||
descriptionParameters:[
|
||||
'link' => [
|
||||
'type' => 'highlight',
|
||||
'id' => 'backgroundjobs',
|
||||
'name' => 'Check the background job settings',
|
||||
'link' => $this->urlGenerator->linkToRoute('settings.AdminSettings.index', ['section' => 'server']) . '#backgroundjobs',
|
||||
],
|
||||
],
|
||||
);
|
||||
} else {
|
||||
return SetupResult::success(
|
||||
$this->l10n->t(
|
||||
'Last background job execution ran %s.',
|
||||
[$relativeTime]
|
||||
)
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
@ -0,0 +1,81 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
/**
|
||||
* @copyright Copyright (c) 2023 Côme Chilliet <come.chilliet@nextcloud.com>
|
||||
*
|
||||
* @author Côme Chilliet <come.chilliet@nextcloud.com>
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
namespace OCA\Settings\SetupChecks;
|
||||
|
||||
use OCP\IConfig;
|
||||
use OCP\IL10N;
|
||||
use OCP\IRequest;
|
||||
use OCP\SetupCheck\ISetupCheck;
|
||||
use OCP\SetupCheck\SetupResult;
|
||||
|
||||
class OverwriteCliUrl implements ISetupCheck {
|
||||
public function __construct(
|
||||
private IL10N $l10n,
|
||||
private IConfig $config,
|
||||
private IRequest $request,
|
||||
) {
|
||||
}
|
||||
|
||||
public function getCategory(): string {
|
||||
return 'config';
|
||||
}
|
||||
|
||||
public function getName(): string {
|
||||
return $this->l10n->t('Overwrite cli URL');
|
||||
}
|
||||
|
||||
public function run(): SetupResult {
|
||||
$currentOverwriteCliUrl = $this->config->getSystemValue('overwrite.cli.url', '');
|
||||
$suggestedOverwriteCliUrl = $this->request->getServerProtocol() . '://' . $this->request->getInsecureServerHost() . \OC::$WEBROOT;
|
||||
|
||||
// Check correctness by checking if it is a valid URL
|
||||
if (filter_var($currentOverwriteCliUrl, FILTER_VALIDATE_URL)) {
|
||||
if ($currentOverwriteCliUrl == $suggestedOverwriteCliUrl) {
|
||||
return SetupResult::success(
|
||||
$this->l10n->t(
|
||||
'The "overwrite.cli.url" option in your config.php is correctly set to "%s".',
|
||||
[$currentOverwriteCliUrl]
|
||||
)
|
||||
);
|
||||
} else {
|
||||
return SetupResult::success(
|
||||
$this->l10n->t(
|
||||
'The "overwrite.cli.url" option in your config.php is set to "%s" which is a correct URL. Suggested URL is "%s".',
|
||||
[$currentOverwriteCliUrl, $suggestedOverwriteCliUrl]
|
||||
)
|
||||
);
|
||||
}
|
||||
} else {
|
||||
return SetupResult::warning(
|
||||
$this->l10n->t(
|
||||
'Please make sure to set the "overwrite.cli.url" option in your config.php file to the URL that your users mainly use to access this Nextcloud. Suggestion: "%s". Otherwise there might be problems with the URL generation via cron. (It is possible though that the suggested URL is not the URL that your users mainly use to access this Nextcloud. Best is to double check this in any case.)',
|
||||
[$suggestedOverwriteCliUrl]
|
||||
)
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Reference in New Issue