From 59cf2b178958c34eaf94aa686ec7024851067c28 Mon Sep 17 00:00:00 2001
From: Joas Schilling <coding@schilljs.com>
Date: Fri, 15 Oct 2021 14:16:08 +0200
Subject: [PATCH] Fix app upgrade

Signed-off-by: Joas Schilling <coding@schilljs.com>
---
 lib/private/Updater.php | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/lib/private/Updater.php b/lib/private/Updater.php
index 6494f7efe0d..2c5820fdd8b 100644
--- a/lib/private/Updater.php
+++ b/lib/private/Updater.php
@@ -273,7 +273,9 @@ class Updater extends BasicEmitter {
 		// upgrade appstore apps
 		$this->upgradeAppStoreApps($appManager->getInstalledApps());
 		$autoDisabledApps = $appManager->getAutoDisabledApps();
-		$this->upgradeAppStoreApps($autoDisabledApps, true);
+		if (!empty($autoDisabledApps)) {
+			$this->upgradeAppStoreApps(array_keys($autoDisabledApps), $autoDisabledApps);
+		}
 
 		// install new shipped apps on upgrade
 		$errors = Installer::installShippedApps(true);
@@ -400,12 +402,12 @@ class Updater extends BasicEmitter {
 	}
 
 	/**
-	 * @param array $disabledApps
-	 * @param bool $reenable
+	 * @param array $apps
+	 * @param array $previousEnableStates
 	 * @throws \Exception
 	 */
-	private function upgradeAppStoreApps(array $disabledApps, bool $reenable = false): void {
-		foreach ($disabledApps as $app => $previousEnableSetting) {
+	private function upgradeAppStoreApps(array $apps, array $previousEnableStates = []): void {
+		foreach ($apps as $app) {
 			try {
 				$this->emit('\OC\Updater', 'checkAppStoreAppBefore', [$app]);
 				if ($this->installer->isUpdateAvailable($app)) {
@@ -414,10 +416,10 @@ class Updater extends BasicEmitter {
 				}
 				$this->emit('\OC\Updater', 'checkAppStoreApp', [$app]);
 
-				if ($reenable) {
+				if (!empty($previousEnableStates)) {
 					$ocApp = new \OC_App();
-					if (!empty($previousEnableSetting)) {
-						$ocApp->enable($app, $previousEnableSetting);
+					if (!empty($previousEnableStates[$app])) {
+						$ocApp->enable($app, $previousEnableStates[$app]);
 					} else {
 						$ocApp->enable($app);
 					}