From 576eef3e0098d2bc1bd9d088b562b2eca62ed28d Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Sat, 10 Feb 2024 22:45:01 +0100 Subject: [PATCH] chore(CI): Migrate samba `files_external` tests from Drone to GitHub Signed-off-by: Ferdinand Thiessen --- .drone.yml | 40 --------- .github/workflows/files-external-smb.yml | 108 +++++++++++++++++++++++ 2 files changed, 108 insertions(+), 40 deletions(-) create mode 100644 .github/workflows/files-external-smb.yml diff --git a/.drone.yml b/.drone.yml index 8da1120c4be..04cdd502fb1 100644 --- a/.drone.yml +++ b/.drone.yml @@ -122,46 +122,6 @@ trigger: - pull_request - push ---- -kind: pipeline -name: samba - -steps: -- name: submodules - image: ghcr.io/nextcloud/continuous-integration-alpine-git:latest - commands: - - git submodule update --init -- name: sqlite-php8.0-samba-native - image: ghcr.io/nextcloud/continuous-integration-samba-native-php8.0:latest - commands: - - smbd -D -FS & - - ./autotest-external.sh sqlite smb-linux - - wget https://codecov.io/bash -O codecov.sh - - sh -c "if [ '$DRONE_BUILD_EVENT' = 'pull_request' ]; then bash codecov.sh -B $DRONE_BRANCH -C $DRONE_COMMIT -P $DRONE_PULL_REQUEST -t 117641e2-a9e8-4b7b-984b-ae872d9b05f5 -f tests/autotest-external-clover-sqlite.xml; fi" - - sh -c "if [ '$DRONE_BUILD_EVENT' != 'pull_request' ]; then bash codecov.sh -B $DRONE_BRANCH -C $DRONE_COMMIT -t 117641e2-a9e8-4b7b-984b-ae872d9b05f5 -f tests/autotest-external-clover-sqlite.xml; fi" - - sh -c "if [ '$DRONE_BUILD_EVENT' = 'pull_request' ]; then bash codecov.sh -B $DRONE_BRANCH -C $DRONE_COMMIT -P $DRONE_PULL_REQUEST -t 117641e2-a9e8-4b7b-984b-ae872d9b05f5 -f tests/autotest-external-clover-sqlite-smb-linux.xml; fi" - - sh -c "if [ '$DRONE_BUILD_EVENT' != 'pull_request' ]; then bash codecov.sh -B $DRONE_BRANCH -C $DRONE_COMMIT -t 117641e2-a9e8-4b7b-984b-ae872d9b05f5 -f tests/autotest-external-clover-sqlite-smb-linux.xml; fi" -# Temporarily disabled because it times out for unknown reasons 98% of the time -#- name: sqlite-php8.0-samba-non-native -# image: ghcr.io/nextcloud/continuous-integration-samba-non-native-php8.0:latest -# commands: -# - smbd -D -FS & -# - ./autotest-external.sh sqlite smb-linux -# - wget https://codecov.io/bash -O codecov.sh -# - sh -c "if [ '$DRONE_BUILD_EVENT' = 'pull_request' ]; then bash codecov.sh -B $DRONE_BRANCH -C $DRONE_COMMIT -P $DRONE_PULL_REQUEST -t 117641e2-a9e8-4b7b-984b-ae872d9b05f5 -f tests/autotest-external-clover-sqlite.xml; fi" -# - sh -c "if [ '$DRONE_BUILD_EVENT' != 'pull_request' ]; then bash codecov.sh -B $DRONE_BRANCH -C $DRONE_COMMIT -t 117641e2-a9e8-4b7b-984b-ae872d9b05f5 -f tests/autotest-external-clover-sqlite.xml; fi" -# - sh -c "if [ '$DRONE_BUILD_EVENT' = 'pull_request' ]; then bash codecov.sh -B $DRONE_BRANCH -C $DRONE_COMMIT -P $DRONE_PULL_REQUEST -t 117641e2-a9e8-4b7b-984b-ae872d9b05f5 -f tests/autotest-external-clover-sqlite-smb-linux.xml; fi" -# - sh -c "if [ '$DRONE_BUILD_EVENT' != 'pull_request' ]; then bash codecov.sh -B $DRONE_BRANCH -C $DRONE_COMMIT -t 117641e2-a9e8-4b7b-984b-ae872d9b05f5 -f tests/autotest-external-clover-sqlite-smb-linux.xml; fi" - -trigger: - branch: - - master - - stable* - event: - - pull_request - - push - - --- kind: signature hmac: e34c8c2ca36355a8dcaf01c7bd14c53bd42d25a4d631533e2c8109e2690c2a98 diff --git a/.github/workflows/files-external-smb.yml b/.github/workflows/files-external-smb.yml new file mode 100644 index 00000000000..42186ed6cd1 --- /dev/null +++ b/.github/workflows/files-external-smb.yml @@ -0,0 +1,108 @@ +name: PHPUnit files_external SMB +on: + pull_request: + schedule: + - cron: "5 2 * * *" + +concurrency: + group: files-external-smb-${{ github.head_ref || github.run_id }} + cancel-in-progress: true + +jobs: + changes: + runs-on: ubuntu-latest-low + + outputs: + src: ${{ steps.changes.outputs.src}} + + steps: + - uses: dorny/paths-filter@0bc4621a3135347011ad047f9ecf449bf72ce2bd # v3.0.0 + id: changes + continue-on-error: true + with: + filters: | + src: + - '.github/workflows/**' + - '3rdparty/**' + - 'apps/files_external/**' + - 'vendor/**' + - 'vendor-bin/**' + - 'composer.json' + - 'composer.lock' + - '**.php' + + files-external-smb: + runs-on: ubuntu-latest + needs: changes + + if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }} + + strategy: + matrix: + php-versions: ['8.0', '8.3'] + include: + - php-versions: '8.0' + coverage: ${{ github.event_name != 'pull_request' }} + + name: php${{ matrix.php-versions }}-smb + + services: + samba: + image: silvershell/samba #ghcr.io/nextcloud/continuous-integration-samba:latest + ports: + - 445:445 + + steps: + - name: Checkout server + uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 + with: + submodules: true + + - name: Set up php ${{ matrix.php-versions }} + uses: shivammathur/setup-php@4bd44f22a98a19e0950cbad5f31095157cc9621b # v2 + with: + php-version: ${{ matrix.php-versions }} + # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation + extensions: ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, smbclient, sqlite, pdo_sqlite + coverage: ${{ matrix.coverage && 'xdebug' || 'none' }} + ini-file: development + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + + - name: Set up smbclient + # This is needed as icewind/smb php library for notify + run: sudo apt-get install -y smbclient + + - name: Set up Nextcloud + run: | + composer install + ./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password + ./occ config:system:set --value true --type boolean allow_local_remote_servers + ./occ app:enable --force files_external + echo "true, 'host'=>'localhost', 'user'=>'test', 'password'=>'test', 'root'=>'', 'share'=>'public'];" > apps/files_external/tests/config.smb.php + + - name: Wait for smb + run: | + apps/files_external/tests/env/wait-for-connection 127.0.0.1 445 60 + + - name: PHPUnit + run: composer run test:files_external -- --verbose \ + apps/files_external/tests/Storage/SmbTest.php \ + ${{ matrix.coverage && ' --coverage-clover ./clover.xml' || '' }} + + - name: Upload code coverage + if: ${{ !cancelled() && matrix.coverage }} + uses: codecov/codecov-action@4fe8c5f003fae66aa5ebb77cfd3e7bfbbda0b6b0 # v3.1.5 + with: + files: ./clover.xml + flags: phpunit-files-external-smb + + files-external-smb-summary: + runs-on: ubuntu-latest-low + needs: [changes, files-external-smb] + + if: always() + + steps: + - name: Summary status + run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-smb.result != 'success' }}; then exit 1; fi