psalm happiness

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

psalm happiness

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

build/psalm-baseline.xml

@@ -1769,9 +1769,6 @@
     </TooManyArguments>
   </file>
   <file src="apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php">
-    <InvalidArrayOffset occurrences="1">
-      <code>$publicData[IAccountManager::PROPERTY_DISPLAYNAME]['value']</code>
-    </InvalidArrayOffset>
     <InvalidScalarArgument occurrences="1">
       <code>$this-&gt;retries + 1</code>
     </InvalidScalarArgument>

lib/private/Accounts/Account.php

@@ -59,7 +59,7 @@ class Account implements IAccount {
 		if ($this->isCollection($property)) {
 			throw new \InvalidArgumentException('getProperty cannot retrieve an IAccountsPropertyCollection');
 		}
-		if (!array_key_exists($property, $this->properties)) {
+		if (!array_key_exists($property, $this->properties) || !$this->properties[$property] instanceof IAccountProperty) {
 			throw new PropertyDoesNotExistException($property);
 		}
 		return $this->properties[$property];

lib/private/Accounts/AccountManager.php

@@ -142,7 +142,7 @@ class AccountManager implements IAccountManager {
 	}
 
 	protected function sanitizeLength(array &$propertyData, bool $throwOnData = false): void {
-		if (isset($propertyData) && isset($propertyData['value']) && strlen($propertyData['value']) > 2048) {
+		if (isset($propertyData['value']) && strlen($propertyData['value']) > 2048) {
 			if ($throwOnData) {
 				throw new \InvalidArgumentException();
 			} else {