Mirror of mitogen
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
Go to file
David Wilson cf01c6b710 importer: avoid duplicate module load(!); closes #113.
Amazed this one managed to scrape through for so long. Calling
__import__ from within find_module() was causing the target module, in
this case cookielib, to be loaded *then overwritten* by a subsequent
duplicate load higher in the stack.

The result is that cookielib was loaded twice, and, per usual Python
import semantics, a reference to the partially initialized first
cookielib was installed in sys.modules while its code executed.

At the end of cookielib on 2.x, it imports _LWPCookieJar, which in turn
imports the partially built cookielib from sys.modules, then subclasses
the CookieJar from /that/ module.

Everything is wonderful. Then the call returns back up into the import
mechanism which restarts the entire process -- only this time,
_LWPCookieJar is /not/ reinitialized, so the copy in sys.modules is
still left with types pointing at the old module!

So the duplicate import creates a new CookieJar which is not the base
class of LWPCookieJar. Tada! 3 hours debugging.

This is probably a performance fix in disguise, didn't realize things
were so broken. It may also be a regression elsewhere. Urgently need to
finish the tests.
7 years ago
ansible_mitogen ansible: redirect logging into display 'framework'. closes #111 7 years ago
docs Pin Sphinx version 7 years ago
examples importer: avoid duplicate module load(!); closes #113. 7 years ago
mitogen importer: avoid duplicate module load(!); closes #113. 7 years ago
tests README: move testing bits into tests directory. 7 years ago
.gitignore Some gitignore extras 7 years ago
.lgtm.yml compat: ignore LGTM checks on third party 7 years ago
.travis.yml Remove overall build timeout from .travis.yml. 7 years ago
LICENSE Add license text everywhere. 7 years ago
README.md README: move testing bits into tests directory. 7 years ago
dev_requirements.txt Move django test script into permanent test 7 years ago
preamble_size.py docs: fix preamble_size.py after whitelist changes 7 years ago
setup.cfg Initial flake8 configuration. 7 years ago
setup.py issue #93: enable use_2to3 to see what happens 7 years ago
test.sh test.sh: make it work on OS X out of the box 7 years ago

README.md