8a34b925a4
The tasks in tests/imageprep/_user_accounts.yml that create users did not specify a primary group for those users - this left the decision to Ansible's user module, and/or the underlying OS. In Ansible 9+ (ansible-core 2.16+ the user module defaults to primary group "staff." Earlier don't supply a default, which releases probably results in a primary group nameed "None" (due to stringifying the Python singleton of the same name), or whatever the macOS Directory Services has for no data/NULL. The invalid GID 4294967295 (MAX_UINT32 == 2**32-1) in the sudo error probably enters the mix via something similar to sudo CVE-2019-14287. Fixes #692 See - https://github.com/ansible/ansible/pull/79999 - https://github.com/ansible/ansible/commit/c69c83c962f987c78af98da0746527df - https://www.sudo.ws/security/advisories/minus_1_uid/ > Bruce Wayne : [confused] Am I meant to understand any of that? > Lucius Fox : Not at all, I just wanted you to know how hard it was. > -- Batman Begins |
1 year ago | |
|---|---|---|
| .. | ||
| bench | 2 years ago | |
| files | 2 years ago | |
| hosts | 1 year ago | |
| integration | 1 year ago | |
| lib | 1 year ago | |
| regression | 1 year ago | |
| setup | 2 years ago | |
| soak | 2 years ago | |
| templates | 1 year ago | |
| tests | 1 year ago | |
| .gitignore | 6 years ago | |
| Makefile | 7 years ago | |
| README.md | 4 years ago | |
| all.yml | 4 years ago | |
| ansible.cfg | 1 year ago | |
| ara_env.py | 7 years ago | |
| compare_output_test.py | 7 years ago | |
| mitogen_ansible_playbook.py | 4 years ago | |
| requirements.txt | 1 year ago | |
| run_ansible_playbook.py | 3 years ago | |
README.md
tests/ansible Directory
This is an an organically growing collection of integration and regression tests used for development and end-user bug reports.
It will be tidied up over time, meanwhile, the playbooks here are a useful demonstrator for what does and doesn't work.
Preparation
run_ansible_playbook.py
This is necessary to set some environment variables used by future tests, as there appears to be no better way to inject them into the top-level process environment before the Mitogen connection process forks.
Running Everything
ANSIBLE_STRATEGY=mitogen_linear ./run_ansible_playbook.py all.yml
hosts/ and common-hosts
To support running the tests against a dev machine that has the requisite user accounts, the the default inventory is a directory containing a 'localhost' file that defines 'localhost' to be named 'target' in Ansible inventory, and a symlink to 'common-hosts', which defines additional targets that all derive from 'target'.
This allows ansible_tests.sh to reuse the common-hosts definitions while
replacing localhost as the test target by creating a new directory that
similarly symlinks in common-hosts.
There may be a better solution for this, but it works fine for now.