Commit Graph

98 Commits (b70803a7632419a8407a881cb774b854368173d2)

Author SHA1 Message Date
David Wilson 4b2170dc81 Wire up ModuleForwarder; closes #3 7 years ago
David Wilson e8b1ebc434 issue #3: Teach core.py the difference between its parent context and the master context.
Needed to allow GET_MODULE calls to reach the parent rather than the
master, when they are not the same context.
7 years ago
David Wilson c7b619a50a It's safe for Waker.on_receive() to drain all bytes.
By the the time Waker.wake() writes to the pipe, any shared state that
would trigger action on the Broker thread has already been updated, so
reading subsequent bytes caused by later Waker.wake() can't miss
anything.

This avoids spewing tons of logs messages every time there is a storm of
user-generated log messages.
7 years ago
David Wilson 821c9dfcb6 Generalize ECONNRESET, EIO handling. 7 years ago
David Wilson 17c2fe68f2 Add Router.enable_debug() rather than cutpasting snippets constantly. 7 years ago
David Wilson a76d871a70 issue #3: Initial ModuleForwarder implementation.
Not wired up yet.
7 years ago
David Wilson a87194a9b8 Uniformly call Context.on_disconnect(), not just for parent. 7 years ago
dmw 64f628d590 fix crash during on_shutdown 7 years ago
David Wilson 4969d7ba61 Fix various bits of bad logging and hard-wired timeouts. 7 years ago
David Wilson 0d0c87f910 Get routing working well. 7 years ago
David Wilson 0a0a060492 Introduce econtext.core.Router, refactor everything
* Header now contains (src, dst) context IDs for routing.
* econtext.context_id now contains current process' context ID.
* Now do 16kb-sized reads rather than 4kb.
* econtext package is uniformly imported in econtext/core.py in slave
  and master.
* Introduce econtext.core.Message() to centralize pickling policy, and
  various function interfaces, may rip it out again later.
* Teach slave/first stage to preserve the copy of econtext.core sent to
  it, so that it can be used for subsequent slave-of-slave bootstraps.
* Disconnect Stream from Context, and teach Context to send messages via
  Router. In this way the Context class works identically for slaves
  directly connected via a Stream, or those for whom other slaves are
  acting as proxies.
* Implement Router, which knows a list of contexts reachable via a
  Stream. Move context registry out of Broker and into Router.
* Move _invoke crap out of stream and into Context.
* Try to avoid pickling on the Broker thread wherever possible.
* Delete connection-specific fields from Context, they live on the
  associated Stream subclass now instead.
* Merge alloc_handle() and add_handle_cb() into add_handler().
* s/enqueue/send/
* Add a hacky guard to prevent send_await() deadlock from Broker thread.
* Temporarily break shutdown logic: graceful shutdown is broken since
  Broker doesn't know about which contexts exist any more.
* Handle EIO in iter_read() too. Also need to support ECONNRESET in here.
* Make iter_read() show last 100 bytes on failure.
* econtext.master.connect() is now econtext.master.Router.connect(),
  move most of the context/stream construction cutpaste into a single
  function, and Stream.construct().
* Stop using sys.executable, since it is the empty string when Python
  has been started with a custom argv[0]. Hard-wire python2.7 for now.
* Streams now have names, which are used as the default name for the
  associated Context during construction. That way Stream<->Context
  association is still fairly obviously and Stream.repr() prints
  something nice.
7 years ago
David Wilson e374f85888 Fix module loader deadlock
Stop using cPickle on the broker thread where it is not known whether
the pickle data would cause the import machinery to be invoked, which
currently relies on blocking calls. Huge mess but it works.

This is due to:

        context.call(some.module.func, another.module.func)

We stringify ("some.module", "func"), but the reference to
another.module.func is passed into the pickle machinery, and there's no
way to generically stringify all function references in user data for
reification on the main thread, without doing something like this
instead.
7 years ago
David Wilson 808af10754 Add sudo to module list. 8 years ago
David Wilson 6c8be56c63 Move write_all() to where it's used. 8 years ago
David Wilson 57a7395b8a Treat EIO like an empty read. 8 years ago
David Wilson 961a9549bd Better method to ensure __module__ is set consistently.
PyFunction_New() and type_new() both simply lookup the __name__ of the
global scope in which a function or class is defined in order to
determine its __module__. So we can do a better job of ensuring
__module__ is set correctly by simply overriding __name__ before
defining any functions or classes.

Works identically in Python 3.
8 years ago
David Wilson 7465e5b283 Add missing econtext.ssh to present list. 8 years ago
David Wilson ff903b1bcd Rearrange docs, split connection methods into submodules. 8 years ago
David Wilson 81dd265c20 Catch BaseException to cope with KeyboardInterrupt and suchlike.
Django's module autoreloader calls sys.exit(), we want to catch that.
8 years ago
David Wilson 965350757f Import working (but useless) connection plugin. 8 years ago
David Wilson 481ae1a933 Implement Importer.get_filename() and Importer.get_source()
Optional importer protocols required for Python to display annotated
tracebacks.
8 years ago
David Wilson ee56032758 Last ditch attempt to log main() thread crashes. 8 years ago
David Wilson 013634a317 Python2.4 lacks any(). 8 years ago
David Wilson 9e68408597 Draft importer tests. 8 years ago
David Wilson 3de06ca559 "Ansible compatible" module loader.
Since all Ansible modules ever written are using worst practice Python,
the module loader must be rewritten to cope with their horrors.

Ansible is woeful software:

* AnsibleModule argument declarations appear within the main() function,
  so they can't be introspected prior to execution.

* No if __name__ == '__main__' guard means they can't be introspected
  without triggering execution.

* By default the main() function attempts to read from stdin, hanging
  our IO thread.

* So much unspeakable crap.

This rewrites the module loader to avoid actually running a module if it
can possibly be avoided. The downside is that the new loader must be
aware of far more details of the Python module mechanism. For example
with the new importer, namespace packages are broken at the very least.

On the plus side, now the module loader will be able to cope with
Django.
8 years ago
David Wilson 088d053a4e Fix Waker repr. 8 years ago
David Wilson 2225ee2923 Convert CallError received on channel into exception. 8 years ago
David Wilson e7c4736b78 Better handle unpicklable objects. 8 years ago
David Wilson 82401c7274 Catch _run_on_thread crashes. 8 years ago
David Wilson a26a6bd66e More docs. 8 years ago
David Wilson fea12a6030 Many updates: graceful shutdown, docs, threading
* Start splitting docs up into internals.rst / api.rst
* Docs for lots more of econtext.core.
* Get rid of _update_stream() and has_output(), replace with individual
  functions called as state changes.
* Add Broker.on_thread() and remove Stream._lock: simply call
  on_thread() to ensure buffer management is linearized.
* Rename read_side/write_side to receive_side/transmit_side like event
  handler names.
* Clean up some more repr / debug logs.
* Move handle cleanup to Context.on_shutdown where it belongs.
* Make wake() a noop when called from broker thread.
* Replace graceful_count crap with Side.graceful attribute, add
  Broker.keep_alive() to check whether any registered readers want to
  be kept alive for graceful shutdown() or any child contexts with a
  connected stream exist.
* Make master.Broker timeout slightly longer than slave broker.
* Add generic on_thread() to allow running code on the IO thread.
8 years ago
David Wilson f83c7c4802 Don't bury EBADF errors. 8 years ago
David Wilson 54b97b12ac Remove pointless _put_reply wrapper. 8 years ago
David Wilson 7c80ca37fd Replace Context lock with code that always runs under GIL 8 years ago
David Wilson a8928b8e05 Remove completely pointless _update_stream lock. 8 years ago
David Wilson 9b4183ddc4 Fix another race.
on_transmit() buffer mutation must be linearized with enqueue() buffer
mutation.
8 years ago
David Wilson 0e38d1f3e3 Remove needless long prefix. 8 years ago
David Wilson ac2a52587b s/wait/join/ 8 years ago
David Wilson 54b0a0aed7 Gracefully handle callback crashes. 8 years ago
David Wilson 2703e444ef Module importer fixes.
* Use TLS to track whether importer is currently running. Avoids
  needing to maintain an ignore stack.

* Print more debugging around cases where Importer skips a module.

* If a module is part of a package, import the package and examine its
  __loader__. If we are not the loader, refuse to load it.
8 years ago
David Wilson e422dedab8 Replace private lock with global importer lock. 8 years ago
David Wilson f88b0a11e9 Python 2.4 fixes. 8 years ago
David Wilson 1bc8681cb4 More doc updates. 8 years ago
David Wilson 6a01ae03e3 Replace SHUTDOWN with Channel.send(_DEAD) 8 years ago
David Wilson da4e457247 More docs, move call/call_with_deadline to econtext.master. 8 years ago
David Wilson c607831561 SlaveModuleImporter->Importer, enable intersphinx, finish howitworks.rst. 8 years ago
David Wilson 737d095ffc More docs. 8 years ago
David Wilson 63ee222406 Many docs updates. 8 years ago
David Wilson 8ba5fbf27f Get rid of CorruptMessageError. 8 years ago
David Wilson 73c418ef4b Rename ContextError -> Error. 8 years ago