The idea behind transport=smart is to select between paramiko and
OpenSSH given the availability of connection multiplexing and/or OSX
kernel bugs. We need to make no such choice.
* origin/dmw:
docs: better intro paragraph.
.ci: copy private key file to tempdir.
os_fork: more doc tweaks
os_fork: more doc tweaks
os_fork: yet more doc tidyup
os_fork: more doc tweaks
os_fork: clean up docs
.ci: import soak scripts.
.ci: allow containers for different jobs to run simultaneously
os_fork: python 3 fixes and tests.
* origin/dmw:
core: increase cookie field lengths to 64-bit; closes#545.
tests: ensure serialization restrictions are in effect
tests/bench: set process affinity in throughput.py.
docs: update copyright year.
docs: update Changelog.
core: Make Latch.put(obj=) optional.
* origin/azure3:
docs: update Changelog; closes#542.
issue #542: return of select poller, new selection logic
issue #542: .ci: move some tests to Azure and enable Mac job.
ansible: create stub __init__.py for sdist.
* origin/dmw:
issue #537: disable just the trivial LinuxPolicyTest on Travis.
docs: update Changelog; closes#537.
ansible: refactor affinity class and add abstract tests.
Bump version for release.
There has always been a race in PushFileService since given a parent
asked to forward modules to two children via some intermediary:
interm = router.local()
c1 = router.local(via=interm)
c2 = router.local(via=interm)
service.propagate_to(c1, 'foo/bar.py')
service.propagate_to(c2, 'foo/bar.py')
Two calls will be emitted to 'interm':
PushFileService.store_and_forward(c1, 'foo/bar.py', [blob])
PushFileService.store(c2, 'foo/bar.py')
Which will be processed in-order up to the point where service pool
threads in 'interm' are woken to process the message.
While it is guaranteed store_and_forward() will be processed first, no
guarantee existed that its assigned pool thread would wake and take
_lock first, thus it was possible for forward() to win the race, and for
a request to arrive to forward a file that had not been placed in local
cache yet.
Here we get rid of SerializedInvoker entirely, as it is partially to
blame for hiding the race: SerializedInvoker can only ensure no two
messages are processed simultaneously, it cannot ensure the messages are
processed in their intended order.
Instead, teach forward() that it may be called before
store_and_forward(), and if that is the case, to place the forward
request on to _waiters alongside any local threads blocked in get().
David Wilson