Commit Graph

2398 Commits (0aa4c9d8fc9d2ffe972b65afa79a979b4e6c2b28)
 

Author SHA1 Message Date
David Wilson 2ad05f1238 issue #251, #412, #434: fix connection configuration brainwrong
This refactors connection.py to pull the two huge dict-building
functions out into new transport_transport_config.PlayContextSpec and
MitogenViaSpec classes, leaving a lot more room to breath in both files
to figure out exactly how connection configuration should work.

The changes made in 1f21a30 / 3d58832 are updated or completely removed,
the original change was misguided, in a bid to fix connection delegation
taking variables from the wrong place when delegate_to was active.

The Python path no longer defaults to '/usr/bin/python', this does not
appear to be Ansible's normal behaviour. This has changed several times,
so it may have to change again, and it may cause breakage after release.

Connection delegation respects the c.DEFAULT_REMOTE_USER whereas the
previous version simply tried to fetch whatever was in the
'ansible_user' hostvar. Many more connection delegation variables closer
match vanilla's handling, but this still requires more work. Some of the
variables need access to the command line, and upstream are in the
process of changing all that stuff around.
6 years ago
David Wilson 8414ff21ca issue #434: tests: set a default remote_user in ansible.cfg. 6 years ago
David Wilson 73a0c485cf tests: CI should symlink all contents of ansible/hosts/ 6 years ago
David Wilson 6ca2677de5 ansible: fix test failure during process exit.
======================================================================
ERROR: tests.connection_test (unittest2.loader._FailedTest)
----------------------------------------------------------------------
Traceback (most recent call last):
ImportError: Failed to import test module: tests.connection_test
Traceback (most recent call last):
  File "/home/dmw/src/mitogen/.venv/local/lib/python2.7/site-packages/unittest2/loader.py", line 456, in _find_test_path
    module = self._get_module_from_name(name)
  File "/home/dmw/src/mitogen/.venv/local/lib/python2.7/site-packages/unittest2/loader.py", line 395, in _get_module_from_name
    __import__(name)
RuntimeError: not holding the import lock
6 years ago
David Wilson 1b8748a8d9 tests: use assert_equal in more places. 6 years ago
David Wilson d72567b15b tests: make assert_equal work on newer Ansibles. 6 years ago
David Wilson 8891b48080 tests: convert stack_construction.yml to assert_equal. 6 years ago
David Wilson 4256d2aa4b tests: make fork_histogram optional 6 years ago
David Wilson 17eff064b0 tests: use assert_equal in delegate_to_template.yml. 6 years ago
David Wilson 91c9aff9ff tests: import assert_equal action. 6 years ago
David Wilson 630c058a89 tests: rename 'delegation/' to 'connection_delegation/' 6 years ago
David Wilson e99b8a8de7 core: replace ancient YOLO loop in fire(). 6 years ago
David Wilson f5d9af80ef tests: some more utility function tests + flake8. 6 years ago
David Wilson 0ba8cc7b61 tests: clean up / deduplicate Ansible inventory. 6 years ago
David Wilson 1555f23215 tests: add some more helper function tests. 6 years ago
David Wilson 63e6fe3f76 Merge remote-tracking branch 'origin/dmw'
* origin/dmw:
  issue #414: reinitialize service pool lock on fork
  issue #414: reenable test.
  core: many docstring updates and an example substitute for Channel
  core: make Receiver a self-closing context manager.
  core: make Receiver.to_sender() use Router.myself().
  docs: update Changelog.
  docs: update Changelog.
6 years ago
David Wilson 1119f24071 issue #414: reinitialize service pool lock on fork 6 years ago
David Wilson 9d9add3339 issue #414: reenable test. 6 years ago
David Wilson 120c667052 core: many docstring updates and an example substitute for Channel 6 years ago
David Wilson 84f75551a3 core: make Receiver a self-closing context manager. 6 years ago
David Wilson fcc403cc2f core: make Receiver.to_sender() use Router.myself(). 6 years ago
David Wilson 581b1e4191 docs: update Changelog. 6 years ago
David Wilson 3561a8a39b Merge remote-tracking branch 'origin/dmw'
* origin/dmw:
  Motivational shame badges back in README
  issue #61: unused import (reported by LGTM)
  issue #61: unused import (reported by LGTM)
  issue #61: unused import (reported by LGTM)
  issue #61: unused import (reported by LGTM)
  issue #61: unused import (reported by LGTM)
  issue #61: unused import (reported by LGTM)
  issue #61: unused import (reported by LGTM)
  issue #61: unused import (reported by LGTM)
  issue #61: unused variable (reported by LGTM)
  issue #61: unused import (reported by LGTM)
  issue #61: unused variable (reported by LGTM)
  issue #61: unused import (reported by LGTM)
  issue #61: unused variable (reported by LGTM)
  issue #61: unused import (reported by LGTM)
  issue #61: fix bare except (reported by LGTM)
  issue #61: unused variable (reported by LGTM)
  issue #61: remove duplicate method (reported by LGTM)
  issue #61: add missing close() implementation (reported by LGTM)
  issue #61: add inverse comparison (reported by LGTM)
  issue #61: remove duplicated method (reported by LGTM)
  issue #424: ansible: make put_file() raise AnsibleFileNotFound
  issue #407: update Changelog.
6 years ago
David Wilson 6dc3389acc docs: update Changelog. 6 years ago
David Wilson 319d32472b Motivational shame badges back in README 6 years ago
David Wilson 6915af502e issue #61: unused import (reported by LGTM) 6 years ago
David Wilson df83c8a02f issue #61: unused import (reported by LGTM) 6 years ago
David Wilson ec515cb663 issue #61: unused import (reported by LGTM) 6 years ago
David Wilson 74d2b43943 issue #61: unused import (reported by LGTM) 6 years ago
David Wilson bc0be45612 issue #61: unused import (reported by LGTM) 6 years ago
David Wilson 6da52ff00e issue #61: unused import (reported by LGTM) 6 years ago
David Wilson d63c99d912 issue #61: unused import (reported by LGTM) 6 years ago
David Wilson 00838e9134 issue #61: unused import (reported by LGTM) 6 years ago
David Wilson 907c4556c8 issue #61: unused variable (reported by LGTM) 6 years ago
David Wilson f67960848b issue #61: unused import (reported by LGTM) 6 years ago
David Wilson 96c35ccab1 issue #61: unused variable (reported by LGTM) 6 years ago
David Wilson 95fe052158 issue #61: unused import (reported by LGTM) 6 years ago
David Wilson b8ca015b83 issue #61: unused variable (reported by LGTM) 6 years ago
David Wilson bcc7bb7128 issue #61: unused import (reported by LGTM) 6 years ago
David Wilson fb750edfa7 issue #61: fix bare except (reported by LGTM) 6 years ago
David Wilson abfb6e39a8 issue #61: unused variable (reported by LGTM) 6 years ago
David Wilson 7bb6b4ab4b issue #61: remove duplicate method (reported by LGTM) 6 years ago
David Wilson 5bd9efb723 issue #61: add missing close() implementation (reported by LGTM) 6 years ago
David Wilson 767737265a issue #61: add inverse comparison (reported by LGTM) 6 years ago
David Wilson 51bd35280a issue #61: remove duplicated method (reported by LGTM) 6 years ago
David Wilson 4bdf60326c issue #424: ansible: make put_file() raise AnsibleFileNotFound 6 years ago
David Wilson 146e0c3ccb issue #407: update Changelog.
Closes #407.
6 years ago
David Wilson 9cd94e7327 Merge remote-tracking branch 'origin/dmw'
* origin/dmw:
  issue #310: fix test failures, teach old import method new tricks
  master: handle crazy non-modules in sys.modules again; closes #310.
  issue #349: update Changelog.
  docs: add unused import to Changelog.
6 years ago
David Wilson 06415bb720 issue #310: fix test failures, teach old import method new tricks
- don't try anything unless something really lives in sys.modules by
  that name
- non-ASCII files are possible
- the unimportable thing might be an extension module, we don't want
  that
6 years ago
David Wilson 6af1a64cce master: handle crazy non-modules in sys.modules again; closes #310. 6 years ago