From dc7fae973b7eafd74d95e84f2aaa43213ef912df Mon Sep 17 00:00:00 2001
From: Alex Willmer <alex@moreati.org.uk>
Date: Tue, 12 Aug 2025 18:11:32 +0100
Subject: [PATCH] CI: Fix ci_lib and test_lib have_<cmd>() when <cmd> exits
 abnormally

We were not raising CalledProcessError when exit status != 0.
---
 .ci/ci_lib.py    | 1 +
 tests/testlib.py | 1 +
 2 files changed, 2 insertions(+)

diff --git a/.ci/ci_lib.py b/.ci/ci_lib.py
index 8193a34c..6a771662 100644
--- a/.ci/ci_lib.py
+++ b/.ci/ci_lib.py
@@ -58,6 +58,7 @@ def _have_cmd(args):
     try:
         subprocess.run(
             args, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL,
+            check=True,
         )
     except OSError as exc:
         if exc.errno == errno.ENOENT:
diff --git a/tests/testlib.py b/tests/testlib.py
index a0e27d95..b91739e6 100644
--- a/tests/testlib.py
+++ b/tests/testlib.py
@@ -160,6 +160,7 @@ def _have_cmd(args):
     try:
         subprocess.run(
             args, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL,
+            check=True,
         )
     except OSError as exc:
         if exc.errno == errno.ENOENT: