From 0d077dc837633a3f1ebff08c933e24e285201721 Mon Sep 17 00:00:00 2001 From: David Wilson Date: Sun, 18 Aug 2019 21:29:37 +0100 Subject: [PATCH 1/9] docs: changelog typos --- docs/changelog.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index 594fdaed..122fa5a4 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -139,7 +139,7 @@ Mitogen for Ansible encoding. * :gh:issue:`602`: connection configuration is more accurately inferred for - :ans:mod:`meta: reset_connection ` the :ans:mod:`synchronize`, and for + :ans:mod:`meta: reset_connection `, the :ans:mod:`synchronize`, and for any action plug-ins that establish additional connections. * :gh:issue:`598`, :gh:issue:`605`: fix a deadlock managing a shared counter @@ -147,9 +147,9 @@ Mitogen for Ansible * :gh:issue:`615`: streaming is implemented for the :ans:mod:`fetch` and other actions that transfer files from targets to the controller. Previously files - delivered were sent in one message, requiring them to fit in RAM and be - smaller than an internal message size sanity check. Transfers from controller - to targets have been streaming since 0.2.0. + were sent in one message, requiring them to fit in RAM and be smaller than an + internal message size sanity check. Transfers from controller to targets have + been streaming since 0.2.0. * :gh:commit:`7ae926b3`: the :ans:mod:`lineinfile` leaks writable temporary file descriptors since Ansible 2.7.0. When :ans:mod:`~lineinfile` created or From c5243e008deea2e1a7b16d4155c5b3a89ccca16d Mon Sep 17 00:00:00 2001 From: David Wilson Date: Sun, 18 Aug 2019 21:29:37 +0100 Subject: [PATCH 2/9] docs: changelog typos --- docs/changelog.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index 122fa5a4..a0bd505e 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -151,11 +151,11 @@ Mitogen for Ansible internal message size sanity check. Transfers from controller to targets have been streaming since 0.2.0. -* :gh:commit:`7ae926b3`: the :ans:mod:`lineinfile` leaks writable temporary - file descriptors since Ansible 2.7.0. When :ans:mod:`~lineinfile` created or - modified a script, and that script was later executed, the execution could - fail with "*text file busy*". Temporary descriptors are now tracked and - cleaned up on exit for all modules. +* :gh:commit:`7ae926b3`: the :ans:mod:`lineinfile` leaked writable temporary + file descriptors between Ansible 2.7.0 and 2.8.2. When :ans:mod:`~lineinfile` + created or modified a script, and that script was later executed, the + execution could fail with "*text file busy*". Temporary descriptors are now + tracked and cleaned up on exit for all modules. Core Library From 7968c4b89f8f3f4349e6b4d95ec16517f85ab697 Mon Sep 17 00:00:00 2001 From: David Wilson Date: Sun, 18 Aug 2019 21:36:12 +0100 Subject: [PATCH 3/9] docs: fix broken changelog link --- docs/changelog.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index a0bd505e..d176ccaf 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -96,8 +96,7 @@ Mitogen for Ansible a broken heuristic in common SELinux policies that prevents inheriting :linux:man7:`unix` sockets across privilege domains. -* `#467 `_: an incompatibility - running Mitogen under `Molecule +* :gh:issue:`467`: an incompatibility running Mitogen under `Molecule `_ was resolved. * :gh:issue:`547`, :gh:issue:`598`: fix a deadlock during initialization of From f95aadc3c570975269f5985f512f125f00f6f6ed Mon Sep 17 00:00:00 2001 From: David Wilson Date: Mon, 19 Aug 2019 00:18:54 +0100 Subject: [PATCH 4/9] docs: another Changelog typo. --- docs/changelog.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index d176ccaf..baecc96b 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -264,7 +264,7 @@ Core Library unidirectional routing, where contexts may optionally only communicate with parents and never siblings (so that air-gapped networks cannot be unintentionally bridged) was not inherited when a child was initiated - directly from an another child. This did not effect Ansible, since the + directly from another child. This did not effect Ansible, since the controller initiates any new child used for routing, only forked tasks are initiated by children. From b02fedc83f8c735f90cb14ce6631ac163fa222e9 Mon Sep 17 00:00:00 2001 From: David Wilson Date: Mon, 19 Aug 2019 02:00:49 +0100 Subject: [PATCH 5/9] docs: add bug links to Changelog. --- docs/changelog.rst | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index baecc96b..5d348aed 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -44,10 +44,9 @@ Enhancements ~~~~~~~~~~~~ * :gh:issue:`556`, - :gh:issue:`587`: Ansible 2.8 is supported. `Become plugins - `_ and - `interpreter discovery - `_ + :gh:issue:`587`: Ansible 2.8 is supported. + `Become plugins `_ (:gh:issue:`631`) and + `interpreter discovery `_ (:gh:issue:`630`) are not yet handled. * :gh:issue:`419`, :gh:issue:`470`: file descriptor usage is approximately From a285488f65405569376741e44c3116a8963bc2a1 Mon Sep 17 00:00:00 2001 From: David Wilson Date: Mon, 19 Aug 2019 02:08:41 +0100 Subject: [PATCH 6/9] docs: insert 'representative' --- docs/changelog.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index 5d348aed..231d69ce 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -67,8 +67,9 @@ Enhancements * :gh:issue:`615`: a modified :ans:mod:`fetch` implements streaming transfer even when ``become`` is active, avoiding excess CPU usage and memory spikes, - and improving performance. A copy of two 512 MiB files drops from 47 seconds - to 7 seconds, with peak memory usage dropping from 10.7 GiB to 64.8 MiB. + and improving performance. A representative copy of two 512 MiB files drops + from 47 seconds to 7 seconds, with peak memory usage dropping from 10.7 GiB + to 64.8 MiB. * `Operon `_ no longer requires a custom library installation, both Ansible and Operon are supported by a single From 146bcd38fb336789565e4d77c1f6928ffcac160b Mon Sep 17 00:00:00 2001 From: David Wilson Date: Mon, 19 Aug 2019 07:04:34 +0100 Subject: [PATCH 7/9] docs: update Changelog note with correct time and add footnote Looking at textedit window before closing, I notice the Mitogen time was taken from /usr/bin/time while the Ansible time was taken from the profile callback plugin. --- docs/changelog.rst | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index 231d69ce..0592101a 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -66,10 +66,10 @@ Enhancements is exposed to Ansible as the :ans:conn:`buildah`. * :gh:issue:`615`: a modified :ans:mod:`fetch` implements streaming transfer - even when ``become`` is active, avoiding excess CPU usage and memory spikes, - and improving performance. A representative copy of two 512 MiB files drops - from 47 seconds to 7 seconds, with peak memory usage dropping from 10.7 GiB - to 64.8 MiB. + even when ``become`` is active, avoiding excess CPU and memory spikes, and + improving performance. A representative copy of two 512 MiB files drops from + 55.7 seconds to 6.3 seconds, with peak memory usage dropping from 10.7 GiB to + 64.8 MiB. [#i615]_ * `Operon `_ no longer requires a custom library installation, both Ansible and Operon are supported by a single @@ -304,6 +304,13 @@ bug reports, testing, features and fixes in this release contributed by `@tho86 `_. +.. rubric:: Footnotes + +.. [#i615] Peak RSS of controller and target as measured with ``/usr/bin/time + -v ansible-playbook -c local`` using the reproduction supplied in + :gh:issue:`615`. + + v0.2.7 (2019-05-19) ------------------- From 03b051ff113b138067b82cfe8a5dcb9eeeed00bc Mon Sep 17 00:00:00 2001 From: David Wilson Date: Tue, 20 Aug 2019 17:06:01 +0100 Subject: [PATCH 8/9] docs: fix link --- docs/changelog.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index 0592101a..8f68e16d 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -30,7 +30,7 @@ Thanks! Mitogen would not be possible without the support of users. A huge thanks for bug reports, testing, features and fixes in this release contributed by -`Can Ozokur httpe://github.com/canozokur/>`_, +`Can Ozokur `_, v0.2.8 (2019-08-18) From 6ea2cef5c5fd68c3b767c2c38c45277e79f92c82 Mon Sep 17 00:00:00 2001 From: Percy Grunwald Date: Sun, 6 Oct 2019 12:52:46 -0700 Subject: [PATCH 9/9] docs: fixes minor typo (pefectly -> perfectly) --- docs/howitworks.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/howitworks.rst b/docs/howitworks.rst index 05c097e5..a856e243 100644 --- a/docs/howitworks.rst +++ b/docs/howitworks.rst @@ -647,7 +647,7 @@ The Module Importer :py:class:`mitogen.core.Importer` is still a work in progress, as there are a variety of approaches to implementing it, and the present implementation -is not pefectly efficient in every case. +is not perfectly efficient in every case. It operates by intercepting :keyword:`import` statements via :py:data:`sys.meta_path`, asking Python if it can satisfy the import by itself,