From 583f540889c9bfcf3c74613938feb811ce4bb0aa Mon Sep 17 00:00:00 2001 From: Steven Robertson Date: Sun, 16 Aug 2020 00:22:08 -0700 Subject: [PATCH] added comments --- ansible_mitogen/mixins.py | 2 +- ansible_mitogen/strategy.py | 1 + mitogen/master.py | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ansible_mitogen/mixins.py b/ansible_mitogen/mixins.py index 116b1c68..ec88e414 100644 --- a/ansible_mitogen/mixins.py +++ b/ansible_mitogen/mixins.py @@ -77,7 +77,7 @@ LOG = logging.getLogger(__name__) try: BaseActionClass = ansible.plugins.action.ActionBase except AttributeError: - # collections were added in https://github.com/ansible/ansible/pull/52194/files + # full collection support was added in v2.10.0 # monkeypatching collections since they don't have an actionBase BaseActionClass = type('DummyActionBase', (object,), {}) diff --git a/ansible_mitogen/strategy.py b/ansible_mitogen/strategy.py index d9afafcc..cb264025 100644 --- a/ansible_mitogen/strategy.py +++ b/ansible_mitogen/strategy.py @@ -54,6 +54,7 @@ except ImportError: Sentinel = None +# TODO: might be possible to lower this back to 2.3 if collection support works without hacks ANSIBLE_VERSION_MIN = (2, 10) ANSIBLE_VERSION_MAX = (2, 10) diff --git a/mitogen/master.py b/mitogen/master.py index 57dc6bf0..8fa089a7 100644 --- a/mitogen/master.py +++ b/mitogen/master.py @@ -155,6 +155,7 @@ def get_child_modules(path, fullname): :return: List of submodule name suffixes. """ + # jjj # TODO: move this somehow to ansible_mitogen, if it's even possible # ISSUE: not everything is being loaded via sys.modules in ansible when it comes to collections # only `action` and `modules` show up in sys.modules[fullname] @@ -520,6 +521,7 @@ class PkgutilMethod(FinderMethod): if not loader: return + # jjj # if fullname == "ansible_collections": # import epdb; epdb.set_trace() # ba = loader.load_module("ansible_collections.alikins")