From 38939b2c1bf57e4d3482bb2c13cd988aa424ca56 Mon Sep 17 00:00:00 2001 From: Steven Robertson Date: Wed, 19 Feb 2020 13:22:40 -0800 Subject: [PATCH] can't run ansible 2.8.0+ tests on ansible < 2.8.0 --- .../ansible_2_8_tests.yml | 295 +++++++++--------- 1 file changed, 149 insertions(+), 146 deletions(-) diff --git a/tests/ansible/integration/interpreter_discovery/ansible_2_8_tests.yml b/tests/ansible/integration/interpreter_discovery/ansible_2_8_tests.yml index cf24167e..4efb3726 100644 --- a/tests/ansible/integration/interpreter_discovery/ansible_2_8_tests.yml +++ b/tests/ansible/integration/interpreter_discovery/ansible_2_8_tests.yml @@ -6,150 +6,153 @@ any_errors_fatal: true gather_facts: true tasks: - - name: ensure we can override ansible_python_interpreter - vars: - ansible_python_interpreter: overriddenpython - assert: - that: - - ansible_python_interpreter == 'overriddenpython' - fail_msg: "'ansible_python_interpreter' appears to be set at a high precedence to {{ ansible_python_interpreter }}, - which breaks this test." - - - name: snag some facts to validate for later - set_fact: - distro: '{{ ansible_distribution | default("unknown") | lower }}' - distro_version: '{{ ansible_distribution_version | default("unknown") }}' - os_family: '{{ ansible_os_family | default("unknown") }}' - - - name: test that python discovery is working and that fact persistence makes it only run once + - name: can only run these tests on ansible >= 2.8.0 block: - - name: clear facts to force interpreter discovery to run - meta: clear_facts - - - name: trigger discovery with auto - vars: - ansible_python_interpreter: auto - ping: - register: auto_out - - - name: get the interpreter being used on the target to execute modules - vars: - ansible_python_interpreter: auto - test_echo_module: - register: echoout - - # can't test this assertion: - # - echoout.ansible_facts is not defined or echoout.ansible_facts.discovered_interpreter_python is not defined - # because Mitogen's ansible_python_interpreter is a connection-layer configurable that - # "must be extracted during each task execution to form the complete connection-layer configuration". - # Discovery won't be reran though; the ansible_python_interpreter is read from the cache if already discovered - - assert: - that: - - auto_out.ansible_facts.discovered_interpreter_python is defined - - echoout.running_python_interpreter == auto_out.ansible_facts.discovered_interpreter_python - - - - name: test that auto_legacy gives a dep warning when /usr/bin/python present but != auto result - block: - - name: clear facts to force interpreter discovery to run - meta: clear_facts - - - name: trigger discovery with auto_legacy - vars: - ansible_python_interpreter: auto_legacy - ping: - register: legacy - - - name: check for dep warning (only on platforms where auto result is not /usr/bin/python and legacy is) - assert: - that: - - legacy.deprecations | default([]) | length > 0 - # only check for a dep warning if legacy returned /usr/bin/python and auto didn't - when: legacy.ansible_facts.discovered_interpreter_python == '/usr/bin/python' and - auto_out.ansible_facts.discovered_interpreter_python != '/usr/bin/python' - - - - name: test that auto_silent never warns and got the same answer as auto - block: - - name: clear facts to force interpreter discovery to run - meta: clear_facts - - - name: initial task to trigger discovery - vars: - ansible_python_interpreter: auto_silent - ping: - register: auto_silent_out - - - assert: - that: - - auto_silent_out.warnings is not defined - - auto_silent_out.ansible_facts.discovered_interpreter_python == auto_out.ansible_facts.discovered_interpreter_python - - - - name: test that auto_legacy_silent never warns and got the same answer as auto_legacy - block: - - name: clear facts to force interpreter discovery to run - meta: clear_facts - - - name: trigger discovery with auto_legacy_silent - vars: - ansible_python_interpreter: auto_legacy_silent - ping: - register: legacy_silent - - - assert: - that: - - legacy_silent.warnings is not defined - - legacy_silent.ansible_facts.discovered_interpreter_python == legacy.ansible_facts.discovered_interpreter_python - - - name: ensure modules can't set discovered_interpreter_X or ansible_X_interpreter - block: - - test_echo_module: - facts: - ansible_discovered_interpreter_bogus: from module - discovered_interpreter_bogus: from_module - ansible_bogus_interpreter: from_module - test_fact: from_module - register: echoout - - - assert: - that: - - test_fact == 'from_module' - - discovered_interpreter_bogus | default('nope') == 'nope' - - ansible_bogus_interpreter | default('nope') == 'nope' - # this one will exist in facts, but with its prefix removed - - ansible_facts['ansible_bogus_interpreter'] | default('nope') == 'nope' - - ansible_facts['discovered_interpreter_bogus'] | default('nope') == 'nope' - - - name: fedora assertions - assert: - that: - - auto_out.ansible_facts.discovered_interpreter_python == '/usr/bin/python3' - when: distro == 'fedora' and distro_version is version('23', '>=') - - - name: rhel assertions - assert: - that: - # rhel 6/7 - - (auto_out.ansible_facts.discovered_interpreter_python == '/usr/bin/python' and distro_version is version('8','<')) or distro_version is version('8','>=') - # rhel 8+ - - (auto_out.ansible_facts.discovered_interpreter_python == '/usr/libexec/platform-python' and distro_version is version('8','>=')) or distro_version is version('8','<') - when: distro in ('redhat', 'centos') - - - name: ubuntu assertions - assert: - that: - # ubuntu < 16 - - (auto_out.ansible_facts.discovered_interpreter_python == '/usr/bin/python' and distro_version is version('16.04','<')) or distro_version is version('16.04','>=') - # ubuntu >= 16 - - (auto_out.ansible_facts.discovered_interpreter_python == '/usr/bin/python3' and distro_version is version('16.04','>=')) or distro_version is version('16.04','<') - when: distro == 'ubuntu' - - - name: mac assertions - assert: - that: - - auto_out.ansible_facts.discovered_interpreter_python == '/usr/bin/python' - when: os_family == 'Darwin' - - always: - - meta: clear_facts + - name: ensure we can override ansible_python_interpreter + vars: + ansible_python_interpreter: overriddenpython + assert: + that: + - ansible_python_interpreter == 'overriddenpython' + fail_msg: "'ansible_python_interpreter' appears to be set at a high precedence to {{ ansible_python_interpreter }}, + which breaks this test." + + - name: snag some facts to validate for later + set_fact: + distro: '{{ ansible_distribution | default("unknown") | lower }}' + distro_version: '{{ ansible_distribution_version | default("unknown") }}' + os_family: '{{ ansible_os_family | default("unknown") }}' + + - name: test that python discovery is working and that fact persistence makes it only run once + block: + - name: clear facts to force interpreter discovery to run + meta: clear_facts + + - name: trigger discovery with auto + vars: + ansible_python_interpreter: auto + ping: + register: auto_out + + - name: get the interpreter being used on the target to execute modules + vars: + ansible_python_interpreter: auto + test_echo_module: + register: echoout + + # can't test this assertion: + # - echoout.ansible_facts is not defined or echoout.ansible_facts.discovered_interpreter_python is not defined + # because Mitogen's ansible_python_interpreter is a connection-layer configurable that + # "must be extracted during each task execution to form the complete connection-layer configuration". + # Discovery won't be reran though; the ansible_python_interpreter is read from the cache if already discovered + - assert: + that: + - auto_out.ansible_facts.discovered_interpreter_python is defined + - echoout.running_python_interpreter == auto_out.ansible_facts.discovered_interpreter_python + + + - name: test that auto_legacy gives a dep warning when /usr/bin/python present but != auto result + block: + - name: clear facts to force interpreter discovery to run + meta: clear_facts + + - name: trigger discovery with auto_legacy + vars: + ansible_python_interpreter: auto_legacy + ping: + register: legacy + + - name: check for dep warning (only on platforms where auto result is not /usr/bin/python and legacy is) + assert: + that: + - legacy.deprecations | default([]) | length > 0 + # only check for a dep warning if legacy returned /usr/bin/python and auto didn't + when: legacy.ansible_facts.discovered_interpreter_python == '/usr/bin/python' and + auto_out.ansible_facts.discovered_interpreter_python != '/usr/bin/python' + + + - name: test that auto_silent never warns and got the same answer as auto + block: + - name: clear facts to force interpreter discovery to run + meta: clear_facts + + - name: initial task to trigger discovery + vars: + ansible_python_interpreter: auto_silent + ping: + register: auto_silent_out + + - assert: + that: + - auto_silent_out.warnings is not defined + - auto_silent_out.ansible_facts.discovered_interpreter_python == auto_out.ansible_facts.discovered_interpreter_python + + + - name: test that auto_legacy_silent never warns and got the same answer as auto_legacy + block: + - name: clear facts to force interpreter discovery to run + meta: clear_facts + + - name: trigger discovery with auto_legacy_silent + vars: + ansible_python_interpreter: auto_legacy_silent + ping: + register: legacy_silent + + - assert: + that: + - legacy_silent.warnings is not defined + - legacy_silent.ansible_facts.discovered_interpreter_python == legacy.ansible_facts.discovered_interpreter_python + + - name: ensure modules can't set discovered_interpreter_X or ansible_X_interpreter + block: + - test_echo_module: + facts: + ansible_discovered_interpreter_bogus: from module + discovered_interpreter_bogus: from_module + ansible_bogus_interpreter: from_module + test_fact: from_module + register: echoout + + - assert: + that: + - test_fact == 'from_module' + - discovered_interpreter_bogus | default('nope') == 'nope' + - ansible_bogus_interpreter | default('nope') == 'nope' + # this one will exist in facts, but with its prefix removed + - ansible_facts['ansible_bogus_interpreter'] | default('nope') == 'nope' + - ansible_facts['discovered_interpreter_bogus'] | default('nope') == 'nope' + + - name: fedora assertions + assert: + that: + - auto_out.ansible_facts.discovered_interpreter_python == '/usr/bin/python3' + when: distro == 'fedora' and distro_version is version('23', '>=') + + - name: rhel assertions + assert: + that: + # rhel 6/7 + - (auto_out.ansible_facts.discovered_interpreter_python == '/usr/bin/python' and distro_version is version('8','<')) or distro_version is version('8','>=') + # rhel 8+ + - (auto_out.ansible_facts.discovered_interpreter_python == '/usr/libexec/platform-python' and distro_version is version('8','>=')) or distro_version is version('8','<') + when: distro in ('redhat', 'centos') + + - name: ubuntu assertions + assert: + that: + # ubuntu < 16 + - (auto_out.ansible_facts.discovered_interpreter_python == '/usr/bin/python' and distro_version is version('16.04','<')) or distro_version is version('16.04','>=') + # ubuntu >= 16 + - (auto_out.ansible_facts.discovered_interpreter_python == '/usr/bin/python3' and distro_version is version('16.04','>=')) or distro_version is version('16.04','<') + when: distro == 'ubuntu' + + - name: mac assertions + assert: + that: + - auto_out.ansible_facts.discovered_interpreter_python == '/usr/bin/python' + when: os_family == 'Darwin' + + always: + - meta: clear_facts + when: ansible_version.full is version('2.8.0', '>=')