From 227cd3aa60a0b42e15e57320379c4aaa353f94fe Mon Sep 17 00:00:00 2001 From: Alex Willmer Date: Sun, 25 Feb 2018 21:53:16 +0000 Subject: [PATCH] ssh, sudo: Remove redundant else clause on bootstrap loop Since the for loops don't contain any break statements the StreamErrors will always be raised when the loop completes without the method resturning. See https://lgtm.com/rules/5980098/ Refs #61 --- mitogen/ssh.py | 3 +-- mitogen/sudo.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/mitogen/ssh.py b/mitogen/ssh.py index a1bc8f18..1db34d5c 100644 --- a/mitogen/ssh.py +++ b/mitogen/ssh.py @@ -126,5 +126,4 @@ class Stream(mitogen.parent.Stream): LOG.debug('sending password') self.transmit_side.write(self.password + '\n') password_sent = True - else: - raise mitogen.core.StreamError('bootstrap failed') + raise mitogen.core.StreamError('bootstrap failed') diff --git a/mitogen/sudo.py b/mitogen/sudo.py index 808f459d..78b9dd7b 100644 --- a/mitogen/sudo.py +++ b/mitogen/sudo.py @@ -107,5 +107,4 @@ class Stream(mitogen.parent.Stream): LOG.debug('sending password') os.write(self.transmit_side.fd, self.password + '\n') password_sent = True - else: - raise mitogen.core.StreamError('bootstrap failed') + raise mitogen.core.StreamError('bootstrap failed')